Support remote endpoint. #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursouza
force-pushed
the
remote_endpoint
branch
2 times, most recently
from
ae18336 to
22c3cfb
Compare
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
remote_endpoint
branch
from
22c3cfb to
9f190d2
Compare
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
| @@ -140,6 +140,10 @@ public void use() { | |||
| System.getProperties().setProperty( | |||
| Properties.API_METHOD_INVOCATION_PROTOCOL.getName(), | |||
| DaprApiProtocol.GRPC.name()); | |||
| System.getProperties().setProperty( | |||
| Properties.GRPC_ENDPOINT.getName(), "http://127.0.0.1:" + this.ports.getGrpcPort()); | |||
There was a problem hiding this comment.
shouldn't this just be 127.0.0.1? Why is there an http prefix?
There was a problem hiding this comment.
It is an endpoint, so the schema is part of it. Users will also use http vs https and the port will be parsed automatically.
There was a problem hiding this comment.
why are we using a http scheme for a gRPC endpoint?
There was a problem hiding this comment.
gRPC can operate over HTTP. In this case, we use to parse the port. The .NET SDK for gRPC communication takes in the entire URL as an endpoint. See https://learn.microsoft.com/en-us/aspnet/core/tutorials/grpc/grpc-start?view=aspnetcore-7.0&tabs=visual-studio#create-the-greeter-client
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
commented
Jun 15, 2023
| String grpcEndpoint = Properties.GRPC_ENDPOINT.get(); | ||
| if ((grpcEndpoint != null) && !grpcEndpoint.isEmpty()) { | ||
| URI uri = URI.create(grpcEndpoint); | ||
| insecure = uri.getScheme().equalsIgnoreCase("http"); |
There was a problem hiding this comment.
See, we use the schema here.
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
============================================
- Coverage 77.82% 77.37% -0.46%
- Complexity 1267 1268 +1
============================================
Files 116 117 +1
Lines 3892 3924 +32
Branches 458 467 +9
============================================
+ Hits 3029 3036 +7
- Misses 630 649 +19
- Partials 233 239 +6
|
mukundansundar
approved these changes
Jun 19, 2023
macromania
pushed a commit
to ISE-Neutrino/java-sdk
that referenced
this pull request
Jun 21, 2023
* Support remote endpoint. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Use GRPC_ENDPOINT and HTTP_ENDPOINT in integration tests. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix happy path for waiting for sidecar test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>
mukundansundar
added a commit
that referenced
this pull request
Sep 13, 2023
* Add ElementType.Type to ActorType (#812) Signed-off-by: LionTao <taojiachun980831@163.com> Signed-off-by: LionTao <taojiachun980831@163.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#788) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update springboot to latest minor.patch version. (#826) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> * Simplification Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Test multiple reminder state types + improve timer tests. (#855) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Convert Config API to Stable endpoints. (#846) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add PubSub subscriber examples over gPRC (#833) * add grpc subscriber Signed-off-by: MregXN <mregxn@gmail.com> * modify README.md Signed-off-by: MregXN <mregxn@gmail.com> * modify README.md in examples Signed-off-by: MregXN <mregxn@gmail.com> * Modify DaprApplication to support examples where protocol is not specified. Signed-off-by: MregXN <mregxn@gmail.com> * modify formatter to pass checkstyle Signed-off-by: MregXN <mregxn@gmail.com> * Update springboot to latest minor.patch version. (#826) Signed-off-by: MregXN <mregxn@gmail.com> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> * Simplification Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * rerun checks Signed-off-by: MregXN <mregxn@gmail.com> * modify the way of grpc server starts Signed-off-by: MregXN <mregxn@gmail.com> * modify README Signed-off-by: MregXN <mregxn@gmail.com> * Update pom.xml Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> --------- Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: champel <champel@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * auto validate actors (#863) Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#862) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Fix 787 (#832) * prepare before testing * Update tests * fix checkstyle --------- Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Upgrade to 1.11 RCs. (#867) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Init for workflows Signed-off-by: Bill DeRusha <billderusha@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Updating some javadocs and Years. Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add missing Header Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * respond to PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update workflow example README Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Address PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixup deprecated pom.xml variable Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Updates based on PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update pom files per feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * GetInstanceState implementation (#1) * addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Management API Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove try/catch Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Implementing getCurrentInstant() authoring method (#5) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Activity Implementation (#3) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixing issue with getIsReplaying() call (#8) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Generate updated javadocs for 1.9.0 (#878) * Generate updated javadocs for 1.9.0 Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Update _index.md Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add .sdkmanrc config file and JDK installation instructions (#873) * Add .sdkmanrc file with installation instructions Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> * Update README.md Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add unit testing example Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix parent pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Send Event Implementation (#10) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Implementing allOf, anyOf, createTimer methods (#11) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> * Support remote endpoint. (#877) * Support remote endpoint. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Use GRPC_ENDPOINT and HTTP_ENDPOINT in integration tests. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix happy path for waiting for sidecar test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add callSubWorkflow Implementation Co-authored-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> * rename DemoSubWorkflow Co-authored-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * continueAsNew Implementation (#13) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove duplicate class Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add missing mockito test dependency Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * use new workflow client implementation Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * moved implementations to new workflow and context Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * relocate duplicate implemantation Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove duplicate test and increase test coverage Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Implement retry and timeout policy for gRPC client. (#889) * Implement retry and timeout policy for gRPC client. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix invoke actor after aborted flow. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * renamed getIsReplaying Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback changes on client Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * move workflow runtime state package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rename workflow instance state to status Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove unnecessary else Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * removed unknown state Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * updated comment Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * updated workflow failure details Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix style issues Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback merge change Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixed pom files Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback actors pom changes on autoformat Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixe actors pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix styling on actors pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix pom spacing Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * move test to match the package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add missing dependencies Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * increased test coverage Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * moved workflow runtime package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add exception for missing case Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add null check for metadata Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add runtime exception error messages Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update try catch scope Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update activity definition to an interface Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update comments Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * removed redundant method Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * PR updates Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> --------- Signed-off-by: LionTao <taojiachun980831@163.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Bill DeRusha <billderusha@microsoft.com> Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Signed-off-by: Mahmut Canga <macromania@users.noreply.github.com> Co-authored-by: LionTao <taojiachun980831@163.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: champel <champel@gmail.com> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: MatejNedic <matejnedic1@gmail.com> Co-authored-by: Bill DeRusha <billderusha@microsoft.com> Co-authored-by: Hannah Kennedy <hakenned@microsoft.com> Co-authored-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Co-authored-by: Aymalla <Aymalla@outlook.com> Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com> Co-authored-by: swetakumari <swetakumari@microsoft.com> Co-authored-by: julio <107879411+julioalex-rezende@users.noreply.github.com> Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Co-authored-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support remote sidecar configuration via consistent env variable.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #876
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: