Implement retry and timeout policy for gRPC client. #889

artursouza · 2023-07-13T23:59:57Z

Description

This is intended as a reference implementation for the proposal to support resiliency in SDKs.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: dapr/dapr#6609

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

artursouza · 2023-08-06T18:19:43Z

sdk-tests/components/mongo-statestore.yml

+      value: testCollection
+scopes:
+  - grpcstateclientit


This is to make it easier to run individual ITs without requiring MongoDB

artursouza · 2023-08-06T18:55:17Z

sdk-tests/src/test/java/io/dapr/it/actors/ActorSdkResiliencytIT.java

+  }
+
+  @Test
+  @Ignore("Flaky when running on GitHub actions")


I spent significant amount of time to remove flakiness. I did fix an issue in AbstractActor because of this test and removed flakiness running locally - not sure why it still flaky in GH Actions.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

sdk-actors/src/main/java/io/dapr/actors/client/DaprGrpcClient.java

mukundansundar · 2023-08-11T12:55:08Z

sdk/src/main/java/io/dapr/utils/Retry.java

-package io.dapr.utils;
-
-class Retry {
-
-  private static final long RETRY_WAIT_MILLISECONDS = 1000;
-
-  private Retry() {
-  }
-
-  static void callWithRetry(Runnable function, long retryTimeoutMilliseconds) throws InterruptedException {


this was used in tests and not being used anymore?

It was only used in the NetworkUtils. So, I moved it there. I want to avoid ambiguity into people thinking this is the RetryPolicy.

isn't this a breaking change?
Though I believe that the users have to use the same package name, to access the method.

Correct. Package here is used for internal scope.

mukundansundar · 2023-08-11T12:55:39Z

LGTM just few questions.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

codecov · 2023-08-11T17:18:07Z

Codecov Report

Merging #889 (919419b) into master (6d65991) will decrease coverage by 0.46%.
The diff coverage is 65.32%.

@@             Coverage Diff              @@
##             master     #889      +/-   ##
============================================
- Coverage     77.49%   77.04%   -0.46%     
- Complexity     1304     1327      +23     
============================================
  Files           123      126       +3     
  Lines          4013     4091      +78     
  Branches        472      484      +12     
============================================
+ Hits           3110     3152      +42     
- Misses          662      693      +31     
- Partials        241      246       +5

Files Changed	Coverage Δ
...a/io/dapr/client/resiliency/ResiliencyOptions.java	`0.00% <0.00%> (ø)`
...rc/main/java/io/dapr/client/DaprClientBuilder.java	`67.56% <33.33%> (-3.87%)`	⬇️
...ava/io/dapr/internal/resiliency/TimeoutPolicy.java	`37.50% <37.50%> (ø)`
...a/io/dapr/config/MillisecondsDurationProperty.java	`50.00% <50.00%> (ø)`
...ain/java/io/dapr/actors/runtime/AbstractActor.java	`83.78% <58.33%> (-1.55%)`	⬇️
...main/java/io/dapr/actors/runtime/ActorManager.java	`80.00% <60.00%> (-1.82%)`	⬇️
.../java/io/dapr/internal/resiliency/RetryPolicy.java	`68.42% <68.42%> (ø)`
...ain/java/io/dapr/actors/client/DaprGrpcClient.java	`88.88% <75.00%> (-4.66%)`	⬇️
sdk/src/main/java/io/dapr/utils/NetworkUtils.java	`83.33% <76.47%> (-5.13%)`	⬇️
...k/src/main/java/io/dapr/client/DaprClientGrpc.java	`89.13% <81.81%> (-0.24%)`	⬇️
... and 2 more

... and 1 file with indirect coverage changes

mukundansundar

lgtm

* Implement retry and timeout policy for gRPC client. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix invoke actor after aborted flow. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>

* Add ElementType.Type to ActorType (#812) Signed-off-by: LionTao <taojiachun980831@163.com> Signed-off-by: LionTao <taojiachun980831@163.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#788) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update springboot to latest minor.patch version. (#826) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> * Simplification Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Test multiple reminder state types + improve timer tests. (#855) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Convert Config API to Stable endpoints. (#846) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add PubSub subscriber examples over gPRC (#833) * add grpc subscriber Signed-off-by: MregXN <mregxn@gmail.com> * modify README.md Signed-off-by: MregXN <mregxn@gmail.com> * modify README.md in examples Signed-off-by: MregXN <mregxn@gmail.com> * Modify DaprApplication to support examples where protocol is not specified. Signed-off-by: MregXN <mregxn@gmail.com> * modify formatter to pass checkstyle Signed-off-by: MregXN <mregxn@gmail.com> * Update springboot to latest minor.patch version. (#826) Signed-off-by: MregXN <mregxn@gmail.com> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <champel@gmail.com> * Simplification Signed-off-by: Sergio <champel@gmail.com> --------- Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> * rerun checks Signed-off-by: MregXN <mregxn@gmail.com> * modify the way of grpc server starts Signed-off-by: MregXN <mregxn@gmail.com> * modify README Signed-off-by: MregXN <mregxn@gmail.com> * Update pom.xml Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> --------- Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: champel <champel@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * auto validate actors (#863) Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#862) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Fix 787 (#832) * prepare before testing * Update tests * fix checkstyle --------- Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Upgrade to 1.11 RCs. (#867) Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Init for workflows Signed-off-by: Bill DeRusha <billderusha@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Updating some javadocs and Years. Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add missing Header Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * respond to PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update workflow example README Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Address PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixup deprecated pom.xml variable Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Updates based on PR feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Update pom files per feedback Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * GetInstanceState implementation (#1) * addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Management API Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove try/catch Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Implementing getCurrentInstant() authoring method (#5) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Activity Implementation (#3) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixing issue with getIsReplaying() call (#8) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> * Generate updated javadocs for 1.9.0 (#878) * Generate updated javadocs for 1.9.0 Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Update _index.md Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add .sdkmanrc config file and JDK installation instructions (#873) * Add .sdkmanrc file with installation instructions Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> * Update README.md Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add unit testing example Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix parent pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Send Event Implementation (#10) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Implementing allOf, anyOf, createTimer methods (#11) Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> * Support remote endpoint. (#877) * Support remote endpoint. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Use GRPC_ENDPOINT and HTTP_ENDPOINT in integration tests. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix happy path for waiting for sidecar test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Add callSubWorkflow Implementation Co-authored-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> * rename DemoSubWorkflow Co-authored-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * continueAsNew Implementation (#13) Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove duplicate class Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add missing mockito test dependency Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * use new workflow client implementation Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * moved implementations to new workflow and context Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * relocate duplicate implemantation Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove duplicate test and increase test coverage Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * Implement retry and timeout policy for gRPC client. (#889) * Implement retry and timeout policy for gRPC client. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Fix invoke actor after aborted flow. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * renamed getIsReplaying Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback changes on client Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * move workflow runtime state package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rename workflow instance state to status Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * remove unnecessary else Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * removed unknown state Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * updated comment Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * updated workflow failure details Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix style issues Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback merge change Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixed pom files Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * rollback actors pom changes on autoformat Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fixe actors pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix styling on actors pom Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * fix pom spacing Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * move test to match the package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add missing dependencies Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * increased test coverage Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * moved workflow runtime package Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add exception for missing case Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add null check for metadata Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * add runtime exception error messages Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update try catch scope Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update activity definition to an interface Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * update comments Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * removed redundant method Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> * PR updates Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> --------- Signed-off-by: LionTao <taojiachun980831@163.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: champel <champel@gmail.com> Signed-off-by: Sergio <champel@gmail.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: MregXN <46479059+MregXN@users.noreply.github.com> Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Bill DeRusha <billderusha@microsoft.com> Signed-off-by: Hannah Kennedy <hakenned@microsoft.com> Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Signed-off-by: Mahmut Canga <macromania@users.noreply.github.com> Co-authored-by: LionTao <taojiachun980831@163.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: champel <champel@gmail.com> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: MatejNedic <matejnedic1@gmail.com> Co-authored-by: Bill DeRusha <billderusha@microsoft.com> Co-authored-by: Hannah Kennedy <hakenned@microsoft.com> Co-authored-by: Bill DeRusha <444835+bderusha@users.noreply.github.com> Co-authored-by: Aymalla <Aymalla@outlook.com> Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com> Co-authored-by: swetakumari <swetakumari@microsoft.com> Co-authored-by: julio <107879411+julioalex-rezende@users.noreply.github.com> Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Co-authored-by: Emanuel Alves <emanuel.j.b.alves@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>

artursouza requested review from a team as code owners July 13, 2023 23:59

artursouza marked this pull request as draft July 14, 2023 00:00

artursouza mentioned this pull request Jul 14, 2023

SDKs to support retry and reconnection to sidecar dapr/dapr#6609

Open

artursouza force-pushed the retry_policy branch from 3452a2c to 75bbd77 Compare July 14, 2023 23:17

artursouza force-pushed the retry_policy branch 12 times, most recently from dc5ec90 to 0488e9f Compare July 29, 2023 06:44

artursouza force-pushed the retry_policy branch 3 times, most recently from 7cf8b41 to 37f00d5 Compare August 6, 2023 16:25

artursouza marked this pull request as ready for review August 6, 2023 18:19

artursouza commented Aug 6, 2023

View reviewed changes

Implement retry and timeout policy for gRPC client.

1d5e2b1

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza force-pushed the retry_policy branch from 37f00d5 to 6573a53 Compare August 11, 2023 01:10

mukundansundar reviewed Aug 11, 2023

View reviewed changes

Fix invoke actor after aborted flow.

919419b

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza force-pushed the retry_policy branch from 6573a53 to 919419b Compare August 11, 2023 17:12

mukundansundar approved these changes Aug 12, 2023

View reviewed changes

artursouza merged commit cf8040d into dapr:master Aug 16, 2023

mukundansundar added this to the v1.10 milestone Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement retry and timeout policy for gRPC client. #889

Implement retry and timeout policy for gRPC client. #889

artursouza commented Jul 13, 2023 •

edited

Loading

artursouza Aug 6, 2023

artursouza Aug 6, 2023

mukundansundar Aug 11, 2023

artursouza Aug 11, 2023

mukundansundar Aug 12, 2023

artursouza Aug 16, 2023

mukundansundar commented Aug 11, 2023

codecov bot commented Aug 11, 2023

mukundansundar left a comment

Implement retry and timeout policy for gRPC client. #889

Implement retry and timeout policy for gRPC client. #889

Conversation

artursouza commented Jul 13, 2023 • edited Loading

Description

Issue reference

Checklist

artursouza Aug 6, 2023

Choose a reason for hiding this comment

artursouza Aug 6, 2023

Choose a reason for hiding this comment

mukundansundar Aug 11, 2023

Choose a reason for hiding this comment

artursouza Aug 11, 2023

Choose a reason for hiding this comment

mukundansundar Aug 12, 2023

Choose a reason for hiding this comment

artursouza Aug 16, 2023

Choose a reason for hiding this comment

mukundansundar commented Aug 11, 2023

codecov bot commented Aug 11, 2023

Codecov Report

mukundansundar left a comment

Choose a reason for hiding this comment

artursouza commented Jul 13, 2023 •

edited

Loading