Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saga pattern support [preview edition] #941

Closed
wants to merge 3 commits into from
Closed

Conversation

skyao
Copy link
Member

@skyao skyao commented Oct 24, 2023

Description

This PR is to add saga pattern support in Dapr java sdk.

The implementation of saga pattern is based on java workflow sdk which has been released in lasted v1.10.0 version.

At this time, This PR is a preview edition:

  • Saga pattern support is still a proposal and under review and discussion.
  • This PR is to help to understand how saga works, and we provide a saga quickstart as demo
  • This PR is not a final version and will keep updating during the proposal review and discussion
  • Don't merge this PR before the proposal is accepted and the design is finalized.

To run the saga quickstart, please reference to:

dapr/quickstarts#954 (comment)

Issue reference

TBD: update here after the proposal is submitted.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@skyao skyao requested review from a team as code owners October 24, 2023 02:21
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@artursouza artursouza self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1bd2c22) 76.58% compared to head (18c61ac) 76.86%.

Files Patch % Lines
...ows/src/main/java/io/dapr/workflows/saga/Saga.java 86.76% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #941      +/-   ##
============================================
+ Coverage     76.58%   76.86%   +0.27%     
- Complexity     1465     1487      +22     
============================================
  Files           137      140       +3     
  Lines          4468     4560      +92     
  Branches        526      535       +9     
============================================
+ Hits           3422     3505      +83     
- Misses          761      768       +7     
- Partials        285      287       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skyao
Copy link
Member Author

skyao commented Nov 16, 2023

@skyao skyao closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants