Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saga pattern support in java-sdk #956

Merged
merged 20 commits into from
Jan 13, 2024
Merged

Conversation

skyao
Copy link
Member

@skyao skyao commented Nov 16, 2023

Description

This PR is to add saga pattern support in Dapr java sdk.

The implementation of saga pattern is based on java workflow sdk which has been released in lasted v1.10.0 version.

At this time, This PR is a preview edition:

  • Saga pattern support is still a proposal and under review and discussion.
  • This PR is to help to understand how saga works, and we provide a saga quickstart as demo
  • This PR is not a final version and will keep updating during the proposal review and discussion
  • Don't merge this PR before the proposal is accepted and the design is finalized.

To run the saga quickstart, please reference to:

dapr/quickstarts#957

Issue reference

#968

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

skyao and others added 6 commits October 24, 2023 01:44
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
…tation

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@skyao skyao changed the title Add saga pattern support(saga-in-workflow) Add Saga pattern support in Java sdk Dec 4, 2023
@skyao skyao changed the title Add Saga pattern support in Java sdk Add Saga pattern support in java-sdk Dec 4, 2023
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fdb4200) 76.85% compared to head (59e76f1) 77.31%.

Files Patch % Lines
...io/dapr/workflows/runtime/OrchestratorWrapper.java 20.00% 3 Missing and 1 partial ⚠️
...ows/src/main/java/io/dapr/workflows/saga/Saga.java 95.55% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #956      +/-   ##
============================================
+ Coverage     76.85%   77.31%   +0.45%     
- Complexity     1497     1537      +40     
============================================
  Files           138      143       +5     
  Lines          4524     4642     +118     
  Branches        530      541      +11     
============================================
+ Hits           3477     3589     +112     
- Misses          773      778       +5     
- Partials        274      275       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit 4a7b985 into dapr:master Jan 13, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants