-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Saga pattern quickstart in Java #957
Conversation
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
how to run this quickstartSince the proposal of saga pattern support is still under review and discussion, the code of saga pattern implementation in dapr java sdk is in preview edition as described in PR dapr/java-sdk#956. install dapr-sdk-workflows locallyTo run this quickstart, we need to build and install dapr-sdk-workflows 0.11.0-SNAPSHOT dependency locally. # clone the PR repo before it's merged
git clone git@github.com:skyao/java-sdk.git
cd java-sdk
# checkout to the saga branch
git checkout saga-in-workflow
# install dapr-sdk-workflows 0.11.0-SNAPSHOT locally
mvn clean install run this quickstart# clone the PR repo before it's merged
git clone git@github.com:skyao/quickstarts.git
cd quickstarts
# checkout to the saga branch
git checkout saga-in-workflow
cd workflow-saga/java/sdk Then reference to the README.md file in |
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@artursouza this PR can merge now. |
Are there any plans to make this available for C#/.net sdk? |
Hey folks. I like this content, but it wasn't ready to be a quickstart, and I'm not sure we even want multiplier quickstarts like this (e.g. a matrix multiplier for Saga). As David's comment points out it also instantly created a "debt" to do this right for all languages, testing and so on. @artursouza I'd ask you to revert this. @msfussell fyi. Then @skyao we should really talk about a proposal for something like this before coding the PR. Or you risk me asking you to back it out and redo it. |
This reverts commit e30c06e.
This reverts commit e30c06e. Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Revert "Add Saga pattern quickstart in Java (#957)" Go failure is ok because has nothing to do with this.
@skyao what do you think about taking your same content, but submitting it as an "example" under the Java sdk repo? The bar is very different for that, and we won't lose the good work here. The very specific folder is right here: https://github.com/dapr/java-sdk/tree/master/examples/src/main/java/io/dapr/examples/workflows |
Description
This PR is to add a quickstart for saga pattern support in java.
At this time, This PR is a preview edition:
Issue reference
TBD: add issue here when the proposal is accepted, and the design is finalized.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: