This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix(bind-*): zone.run scope.apply on bind- change events #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -309,6 +309,9 @@ class ElementBinder { | |||
| bindAssignableProps.forEach((propAndExp) { | |||
| propAndExp[1].assign(scope.context, jsNode[propAndExp[0]]); | |||
| }); | |||
| // due to https://code.google.com/p/dart/issues/detail?id=17406 | |||
| // we have to manually run the zone. | |||
| Zone.current.run(scope.apply); | |||
There was a problem hiding this comment.
Run the entire addEventListener callback in a Zone.current.run; Angular will automatically apply().
You want to run it in the current Zone at the time or registration, so you'll need to store a reference to Zone.current.
Due to dart bug, events registered with addEventListener do no fire scope.apply(). Adds an example of an affected polymer component.
rkirov
force-pushed
the
ng-polymer-bugs
branch
from
0b96007 to
241eba2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to dart bug, events registered with addEventListener do no fire
scope.apply().
Adds an example of an affected polymer component.