Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

feat(web components): Support custom events for element property binding #1453

Closed
wants to merge 1 commit into from
Closed

feat(web components): Support custom events for element property binding #1453

wants to merge 1 commit into from

Conversation

jbdeboer
Copy link
Contributor

Closes #1449

rkirov
rkirov reviewed Sep 12, 2014
View reviewed changes
lib/core_dom/element_binder.dart
@@ -59,6 +59,20 @@ class ElementBinder {
bool get shouldCompileChildren =>
childMode == Directive.COMPILE_CHILDREN;

List<String> _bindAssignablePropsOnCache;
List<String> get _bindAssignablePropsOn {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, when do we call bind multiple times on a single ElementBinder (otherwise the cache is not necessary)?

@rkirov
Copy link
Contributor

rkirov commented Sep 12, 2014

LGTM.

@rkirov
Copy link
Contributor

rkirov commented Sep 12, 2014

Putting it as rebase since it would need a trivial rebase once I get #1448 in (running presubmit now).

jbdeboer added a commit that referenced this pull request Sep 15, 2014
@jbdeboer
feat(web components): Support custom events for element property binding
0b9fe5f 
Closes #1449
Closes #1453
@jbdeboer jbdeboer closed this in 94c3522 Sep 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge cla: yes status: LGTM status: Travis OK
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for polymer components that don't fire change events
3 participants
@jbdeboer @rkirov @mhevery