Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

<fix>(transformers): Fix relative URL lookup for transformers, and web assets #1650

Closed
wants to merge 1 commit into from
Closed

<fix>(transformers): Fix relative URL lookup for transformers, and web assets #1650

wants to merge 1 commit into from

Conversation

TedSander
Copy link
Contributor

Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Closes #1649

@rkirov rkirov self-assigned this Jan 21, 2015
@chirayuk
Copy link
Contributor

LGTM.

@rkirov rkirov mentioned this pull request Jan 27, 2015
Closed
<fix>(transformers): Fix relative URL lookup for transformers, and web
6f707d7 
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes dart-archive#1649, dart-archive#1651
@TedSander TedSander force-pushed the ResolvedUrlForTransformers branch from 840fb65 to 6f707d7 Compare January 27, 2015 21:47
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@TedSander TedSander changed the title <fix>(transformers): Fix relative URL lookup for transformers <fix>(transformers): Fix relative URL lookup for transformers, and web assets Jan 27, 2015
@TedSander
Copy link
Contributor Author

Merged Pull request for #1652 into this one. I think it is ready for a merge.

@mhevery
Copy link
Contributor

mhevery commented Jan 27, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 27, 2015

Achievement unlocked: CLA signature found!

12 similar comments
@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 1, 2015

Achievement unlocked: CLA signature found!

@austincummings
Copy link

What the hell happened here?

@mhevery
Copy link
Contributor

mhevery commented Feb 1, 2015

Achievement unlocked: CLA signature found!

24 similar comments
@mhevery
Copy link
Contributor

mhevery commented Feb 1, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 1, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@mhevery
Copy link
Contributor

mhevery commented Feb 2, 2015

Achievement unlocked: CLA signature found!

@rkirov rkirov removed the cla: no label Feb 2, 2015
@rkirov rkirov closed this Feb 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes status: LGTM
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expression Generator Transformer does not respect relative resources
7 participants
@TedSander @chirayuk @googlebot @mhevery @bgourlie @austincummings @rkirov