This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Removed unnecessary nullable type in maxBy #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Sep 13, 2021
| @@ -86,7 +86,7 @@ S? minBy<S, T>(Iterable<S> values, T Function(S) orderBy, | |||
| /// compared using their [Comparable.compareTo]. | |||
| /// | |||
| /// Returns `null` if [values] is empty. | |||
| S? maxBy<S, T>(Iterable<S> values, T Function(S?) orderBy, | |||
| S? maxBy<S, T>(Iterable<S> values, T Function(S) orderBy, | |||
lrhn
approved these changes
Sep 13, 2021
|
This change causes errors in google3 and is causing pain trying to get the package rolled through. @mit-mit - A data point that a cbuild like system for package PRs would be a big help so we find out before it becomes a blocker. |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
* Removed unnecessary nullable type in maxBy * Update functions_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.