Removed unnecessary nullable type in maxBy (dart-archive/collection#181)

* Removed unnecessary nullable type in maxBy * Update functions_test.dart
dart-lang · Sep 13, 2021 · 8764c3f · 8764c3f
1 parent efb6a82
commit 8764c3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkgs/collection/lib/src/functions.dart b/pkgs/collection/lib/src/functions.dart
@@ -86,7 +86,7 @@ S? minBy<S, T>(Iterable<S> values, T Function(S) orderBy,
 /// compared using their [Comparable.compareTo].
 ///
 /// Returns `null` if [values] is empty.
-S? maxBy<S, T>(Iterable<S> values, T Function(S?) orderBy,
+S? maxBy<S, T>(Iterable<S> values, T Function(S) orderBy,
     {int? Function(T, T)? compare}) {
   compare ??= defaultCompare;
 

diff --git a/pkgs/collection/test/functions_test.dart b/pkgs/collection/test/functions_test.dart
@@ -162,7 +162,7 @@ void main() {
             {'foo': 4},
             {'foo': 1},
             {'foo': 2}
-          ], (map) => map!,
+          ], (map) => map,
               compare: (map1, map2) => map1['foo']!.compareTo(map2['foo']!)),
           equals({'foo': 5}));
     });