This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
enable the avoid_dynamic_calls lint #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
suggested changes
Feb 16, 2022
lib/src/equality.dart
Outdated
| @@ -212,7 +212,7 @@ abstract class _UnorderedEquality<E, T extends Iterable<E>> | |||
| bool equals(T? elements1, T? elements2) { | |||
| if (identical(elements1, elements2)) return true; | |||
| if (elements1 == null || elements2 == null) return false; | |||
| var counts = HashMap( | |||
| var counts = HashMap<E, int?>( | |||
There was a problem hiding this comment.
We should only assign non-null ints.
Suggested change
| var counts = HashMap<E, int?>( | |
| var counts = HashMap<E, int>( |
There was a problem hiding this comment.
Yeah, but if you look down a few lines, we read from this as well:
var count = counts[e] ?? 0;
And counts[e] could return a null. I suppose I could use something like Map.update() to avoid the using a nullable type, but using a nullable type seems simpler here.
There was a problem hiding this comment.
The null is only when e isn't a present key in the map. We don't need the generic on the map to be nullable.
There was a problem hiding this comment.
Ah, yup, that's the case; I'll make this non-nullable.
natebosch
approved these changes
Feb 18, 2022
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
enable the avoid_dynamic_calls lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid_dynamic_callslintints being added to a map)