enable the avoid_dynamic_calls lint (dart-archive/collection#232)

enable the avoid_dynamic_calls lint
dart-lang · Feb 18, 2022 · 4d6899b · 4d6899b
1 parent 3c3f34e
commit 4d6899b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/pkgs/collection/CHANGELOG.md b/pkgs/collection/CHANGELOG.md
@@ -11,7 +11,7 @@
   Assignment to `Equality` with a nullable type is still allowed because of
   covariance. The `equals` and `hash` methods continue to accept nullable
   arguments.
-
+* Enable the `avoid_dynamic_calls` lint.
 
 ## 1.15.0
 

diff --git a/pkgs/collection/analysis_options.yaml b/pkgs/collection/analysis_options.yaml
@@ -1,6 +1,9 @@
 include: package:lints/recommended.yaml
+
 linter:
   rules:
+    - avoid_dynamic_calls
+
     # Errors
     - test_types_in_equals
     - throw_in_finally

diff --git a/pkgs/collection/lib/src/equality.dart b/pkgs/collection/lib/src/equality.dart
@@ -212,7 +212,7 @@ abstract class _UnorderedEquality<E, T extends Iterable<E>>
   bool equals(T? elements1, T? elements2) {
     if (identical(elements1, elements2)) return true;
     if (elements1 == null || elements2 == null) return false;
-    var counts = HashMap(
+    var counts = HashMap<E, int>(
         equals: _elementEquality.equals,
         hashCode: _elementEquality.hash,
         isValidKey: _elementEquality.isValidKey);

diff --git a/pkgs/collection/test/analysis_options.yaml b/pkgs/collection/test/analysis_options.yaml
@@ -0,0 +1,6 @@
+include: ../analysis_options.yaml
+
+# Turn off the avoid_dynamic_calls lint for the test/ directory.
+analyzer:
+  errors:
+    avoid_dynamic_calls: ignore