Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

issue #40 route always emptied title field with no reason - title is no ... #41

Closed
wants to merge 1 commit into from

Conversation

pcornelissen
Copy link
Contributor

...longer touched

To avoid that angular interferes with the apps title it is no longer removed. Currently there seem to be preparations to solve issue #10 which asks to set the title on a per route basis, which is a good idea, but the old code breaks applications that try to set the title by themselves. (Or at least produces unnecessary work, by removing the title)

My patch solves that by only setting the title when it is actually provided, so you should have no effort when the title handling is really implemented.

@pavelgj
Copy link
Contributor

pavelgj commented Apr 25, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@pcornelissen
Copy link
Contributor Author

Hi Pavel,
I signed the CLA digitally.
If necessary I can fax something, but as it's an international call, I'd
like to avoid that. ;-)

I used my business emailaddress pcornelissen@orchit.de, as the contribution
was via the company repository.

2014-04-25 17:56 GMT+02:00 Pavel Jbanov notifications@github.com:

Thanks for your contribution! In order for us to be able to accept it, we
ask you to sign our CLA (contributor's license agreement). CLA is important
for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html


Reply to this email directly or view it on GitHubhttps://github.com//pull/41#issuecomment-41408711
.

Mit freundlichen Grüßen,
Patrick Cornelißen
http://www.pcornelissen.de
http://www.orchit.de

@pavelgj
Copy link
Contributor

pavelgj commented Apr 25, 2014

Thank you. Merged via 81a4f10 -- I took the liberty of fixing the tests as part of the same commit.

@pavelgj pavelgj closed this Apr 25, 2014
@pcornelissen
Copy link
Contributor Author

Argh, sorry I missed that.

2014-04-25 18:34 GMT+02:00 Pavel Jbanov notifications@github.com:

Thank you. Merged via 81a4f1081a4f10e390d43769605a7676adb8ad59c42c297-- I took the liberty of fixing the tests as part of the same commit.


Reply to this email directly or view it on GitHubhttps://github.com//pull/41#issuecomment-41412819
.

Mit freundlichen Grüßen,
Patrick Cornelißen
http://www.pcornelissen.de
http://www.orchit.de

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants