This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
issue #40 route always emptied title field with no reason - title is no ... #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...longer touched
To avoid that angular interferes with the apps title it is no longer removed. Currently there seem to be preparations to solve issue #10 which asks to set the title on a per route basis, which is a good idea, but the old code breaks applications that try to set the title by themselves. (Or at least produces unnecessary work, by removing the title)
My patch solves that by only setting the title when it is actually provided, so you should have no effort when the title handling is really implemented.