Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix(avoid-passing-async-when-sync-expected): FutureOr Functions are… #1036

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Oct 14, 2022

… interpreted as synchronous functions

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

  • Add case in example
  • I change the condition to check if parameter is async or not

Is there anything you'd like reviewers to focus on?

No

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #1036 (9f001a2) into master (5cf4c85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1036   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files         327      327           
  Lines        7022     7023    +1     
=======================================
+ Hits         6099     6100    +1     
  Misses        923      923           
Impacted Files Coverage Δ
...void_passing_async_when_sync_expected/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial self-requested a review October 14, 2022 15:58
@incendial incendial added this to the 5.0.0 milestone Oct 14, 2022
Copy link
Member

@incendial incendial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🔥

@incendial incendial merged commit 1ab388a into dart-code-checker:master Oct 14, 2022
@lsaudon lsaudon deleted the fix-futureor branch October 14, 2022 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants