fix(avoid-passing-async-when-sync-expected): FutureOr Functions are…

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 4.21.2
+
+* fix(avoid-passing-async-when-sync-expected): FutureOr Functions are interpreted as synchronous functions
+
 ## 4.21.1
 
 * fix: stop plugin flickering after migration to new api.

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_passing_async_when_sync_expected/visitor.dart

@@ -29,7 +29,8 @@ class _Visitor extends RecursiveAstVisitor<void> {
       final parameterType = argument.staticParameterElement?.type;
       if (argumentType is FunctionType && parameterType is FunctionType) {
         if (argumentType.returnType.isDartAsyncFuture &&
-            !parameterType.returnType.isDartAsyncFuture) {
+            (!parameterType.returnType.isDartAsyncFuture &&
+                !parameterType.returnType.isDartAsyncFutureOr)) {
           _invalidArguments.add(argument);
         }
       }

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_passing_async_when_sync_expected/examples/example.dart

@@ -88,4 +88,10 @@ class _MyHomePageState extends State<MyHomePage> {
       ),
     );
   }
+
+  Future<String> doSomeGetRequest() => Future.value('');
+
+  Future<String> doAnotherGetRequest(String input) => Future.value('');
+
+  Future<String> main() => doSomeGetRequest().then(doAnotherGetRequest);
 }