Remove build->build_runner_core dependency #4172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
remove-cycle
branch
from
31b69df to
089e328
Compare
jensjoha
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...except for one method
runBuilder, its implementation is moved tobuild_runner_corewithout changes inrun_builder.dart. A forwarding method is left inpackage:buildand marked deprecated.NoOpStageTrackeris an implementation detail ofrunBuilder, a default for one of the args, so it moves with it tobuild_runner_core.No other changes to code besides updating imports as needed, and moving tests to where the impls now live.
Remove package deps from
package:buildthat are no longer used.