Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for CyclicInitializationError #1586

Closed
alexmarkov opened this issue Dec 13, 2022 · 1 comment
Closed

Remove tests for CyclicInitializationError #1586

alexmarkov opened this issue Dec 13, 2022 · 1 comment
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@alexmarkov
Copy link

CyclicInitializationError is deprecated and about to be removed. Please remove these tests both from co19 and co19_2:
https://github.com/search?q=repo%3Adart-lang%2Fco19%20CyclicInitializationError&type=code
@sgrekhov sgrekhov self-assigned this Dec 14, 2022
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 14, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 14, 2022
@sgrekhov
dart-lang#1586. Remove CyclicInitializationError from co19_2 tests
3d6eb49
@sgrekhov
Copy link
Contributor

Please see #1590 and #1591. Note that there are still mentions of CyclicInitializationError in the assertions text (which are cite from the specification), but this will be updated after dart-lang/language#2720

eernstg pushed a commit that referenced this issue Dec 14, 2022
@sgrekhov
#1586. Remove CyclicInitializationError from co19_2 tests (#1591)
fa1aa99 
Authored by @sgrekhov.
@sgrekhov sgrekhov mentioned this issue Dec 15, 2022
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 16, 2022
@sgrekhov
[co19] Roll co19_2 to f691647f1c2cc4f1019fb619932c52d0a1adbf2c
aac2b2e 
2022-12-15 sgrekhov22@gmail.com Fixes dart-lang/co19#1595. Expect TypeError in place of NullThrownError in co19_2 tests (dart-lang/co19#1597)
2022-12-14 sgrekhov22@gmail.com dart-lang/co19#1586. Remove CyclicInitializationError from co19_2 tests (dart-lang/co19#1591)
2022-12-13 sgrekhov22@gmail.com dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1585)

Change-Id: Icbf31546935281067815d59957ed2ddc7e262546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275921
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @alexmarkov