Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1586. Remove CyclicInitializationError from co19_2 tests #1591

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit fa1aa99 into dart-lang:pre-nnbd Dec 14, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 16, 2022
2022-12-15 sgrekhov22@gmail.com Fixes dart-lang/co19#1595. Expect TypeError in place of NullThrownError in co19_2 tests (dart-lang/co19#1597)
2022-12-14 sgrekhov22@gmail.com dart-lang/co19#1586. Remove CyclicInitializationError from co19_2 tests (dart-lang/co19#1591)
2022-12-13 sgrekhov22@gmail.com dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1585)

Change-Id: Icbf31546935281067815d59957ed2ddc7e262546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275921
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
@sgrekhov sgrekhov deleted the co19_2-1586 branch December 26, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants