Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of NullThrownError in co19/LibTest/async/Future / Future.error_A01_t01.dart #1599

Closed
nshahan opened this issue Dec 15, 2022 · 2 comments
Closed

Remove use of NullThrownError in co19/LibTest/async/Future / Future.error_A01_t01.dart #1599

nshahan opened this issue Dec 15, 2022 · 2 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@nshahan
Copy link

nshahan commented Dec 15, 2022

We need to cleanup the use of the NullThrownError so it can be removed from the SDK. I believe TypeError suffice here.

co19/LibTest/async/Future/Future.error_A01_t01.dart

Line 21 in be8f8ae

Expect.isTrue(error is NullThrownError);

@nshahan nshahan added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 15, 2022
@nshahan
Copy link
Author

nshahan commented Dec 15, 2022

A legacy version of this test also exists that needs to be fixed as well.

co19_2/LibTest/async/Future/Future.error_A01_t01

@sgrekhov sgrekhov self-assigned this Dec 16, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 16, 2022
@sgrekhov
dart-lang#1599. Expect TypeError in place of NullThrownError in co19 …
034e4c5 
…tests
eernstg pushed a commit that referenced this issue Dec 16, 2022
@sgrekhov
#1599. Expect TypeError in place of NullThrownError in co19 tests (#1600
21fcd48 
)
@sgrekhov
Copy link
Contributor

Legacy version of this test was fixed by #1597. Roll of co19_2 should be completed and yhe changes shoule be enebled

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 21, 2022
@sgrekhov @athomas
[co19] Roll co19 to f4bd100ed6fe9a1f9a98d6e4163d742824fbf21c
0c87c84 
2022-12-20 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Object pattern tests (dart-lang/co19#1602)
2022-12-20 sgrekhov22@gmail.com Fixes dart-lang/co19#1539. Rename "views" experimental flag to "inline-class" (dart-lang/co19#1596)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.1.0 to 3.2.0 (dart-lang/co19#1607)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.8.0 to 3.9.0 (dart-lang/co19#1608)
2022-12-19 sgrekhov22@gmail.com dart-lang/co19#1604. Update errors expectations for metadata parsing (dart-lang/co19#1605)
2022-12-19 sgrekhov22@gmail.com Fixes dart-lang/co19#1601. Expect compile-time error for elementAt() invocation on not a constant (dart-lang/co19#1603)
2022-12-16 sgrekhov22@gmail.com dart-lang/co19#1599. Expect TypeError in place of NullThrownError in co19 tests (dart-lang/co19#1600)

Change-Id: I490806d7116f66dc294921561bdec350039e44f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276901
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @sgrekhov