Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1599. Expect TypeError in place of NullThrownError in co19 tests #1600

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 21fcd48 into dart-lang:master Dec 16, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 21, 2022
2022-12-20 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Object pattern tests (dart-lang/co19#1602)
2022-12-20 sgrekhov22@gmail.com Fixes dart-lang/co19#1539. Rename "views" experimental flag to "inline-class" (dart-lang/co19#1596)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.1.0 to 3.2.0 (dart-lang/co19#1607)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.8.0 to 3.9.0 (dart-lang/co19#1608)
2022-12-19 sgrekhov22@gmail.com dart-lang/co19#1604. Update errors expectations for metadata parsing (dart-lang/co19#1605)
2022-12-19 sgrekhov22@gmail.com Fixes dart-lang/co19#1601. Expect compile-time error for elementAt() invocation on not a constant (dart-lang/co19#1603)
2022-12-16 sgrekhov22@gmail.com dart-lang/co19#1599. Expect TypeError in place of NullThrownError in co19 tests (dart-lang/co19#1600)

Change-Id: I490806d7116f66dc294921561bdec350039e44f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276901
Reviewed-by: Alexander Thomas <athom@google.com>
@sgrekhov sgrekhov deleted the co19-1599 branch December 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants