Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to 5c18c223a9c58768db417673d9d252e6f54e8d09 #2572

Closed
sgrekhov opened this issue Mar 15, 2024 · 1 comment
Closed

Failures on [co19] Roll co19 to 5c18c223a9c58768db417673d9d252e6f54e8d09 #2572

sgrekhov opened this issue Mar 15, 2024 · 1 comment
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@sgrekhov
Copy link
Contributor

There are new test failures on [co19] Roll co19 to 5c18c223a9c58768db417673d9d252e6f54e8d09.

The tests

co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A01_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A01_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t01 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t02 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t02 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t01 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t02 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t01 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A04_t01 MissingCompileTimeError (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t01_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t02_lib1 Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t02_lib2 Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t01_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t02_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t01_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t02_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t01_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t02_lib1 Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t02_lib2 Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/defining_augmentation_A04_t01_lib Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Augmentation-libraries/defining_augmentation_A04_t02_lib Fail (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-unittest-asserts-release-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
ddc-linux-chrome
ddc-linux-chrome-unsound
vm-mac-debug-arm64
vm-win-release-x64
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Mar 15, 2024
@sgrekhov sgrekhov self-assigned this Mar 15, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Mar 15, 2024
@sgrekhov
Fixes dart-lang#2572. Fix roll failures
07588f9
@sgrekhov
Copy link
Contributor Author

Triaged

Failure Issue
analyzer-asserts-linux  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t02 dart-lang/sdk#55204
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t01 Fixed
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t01 dart-lang/sdk#55205
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t02 dart-lang/sdk#55205
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t01 dart-lang/sdk#55113
analyzer-asserts-linux  
cfe...  
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A04_t01 dart-lang/sdk#49416
analyzer-asserts-linux  
cfe...  
dart2js...  
dart2wasm...  
ddc...  
vm...  
new test -> CompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t02 dart-lang/sdk#49416
cfe...  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t01 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A02_t02 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t01 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A04_t02 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/defining_augmentation_A03_t01 dart-lang/sdk#49416
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A01_t01 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A01_t03 dart-lang/sdk#49416
co19/LanguageFeatures/Augmentation-libraries/applying_augmentation_library_A03_t01 dart-lang/sdk#49416

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 3, 2024
@sgrekhov @athomas
[co19] Roll co19 to 74b618cc11ea65ced9e017f58893cf565b7b21b9
35153da 
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting itself tests (dart-lang/co19#2567)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 1 (dart-lang/co19#2568)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add merge order tests (dart-lang/co19#2566)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 4 (dart-lang/co19#2571)
2024-03-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2572. Fix roll failures (dart-lang/co19#2573)
2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add applying augmentation library tests (dart-lang/co19#2564)
2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for augment libraries errors (dart-lang/co19#2562)
2024-03-08 sgrekhov22@gmail.com Fixes dart-lang/co19#2558. Remove `inline-class` experimental flag (dart-lang/co19#2563)

R=kustermann@google.com, pquitslund@google.com

Change-Id: Icdfcf44ecc525c1a673ec8024577cbcdfd316eb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359440
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov