#2559. Add tests for augment libraries errors #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has the same issues as #2561. So, converted it to a draft. Will bring it back to review after fixing the issues |
|
Ready for review now |
eernstg
approved these changes
Mar 11, 2024
LanguageFeatures/Augmentation-libraries/defining_augmentation_A04_t01.dart
Show resolved
Hide resolved
|
One little thing about the terminology: The entry point is a library, and it needs to be a 'script' (in the sense that the language specification uses), that is, it must export a top-level function called So it's not a problem to have a |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 3, 2024
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting itself tests (dart-lang/co19#2567) 2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 1 (dart-lang/co19#2568) 2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add merge order tests (dart-lang/co19#2566) 2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 4 (dart-lang/co19#2571) 2024-03-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2572. Fix roll failures (dart-lang/co19#2573) 2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add applying augmentation library tests (dart-lang/co19#2564) 2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for augment libraries errors (dart-lang/co19#2562) 2024-03-08 sgrekhov22@gmail.com Fixes dart-lang/co19#2558. Remove `inline-class` experimental flag (dart-lang/co19#2563) R=kustermann@google.com, pquitslund@google.com Change-Id: Icdfcf44ecc525c1a673ec8024577cbcdfd316eb0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359440 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.