Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to 67a43c466e367503f19a71a6f2260049698f6c1e #2756

Closed
sgrekhov opened this issue Jul 5, 2024 · 1 comment
Closed

Failures on [co19] Roll co19 to 67a43c466e367503f19a71a6f2260049698f6c1e #2756

sgrekhov opened this issue Jul 5, 2024 · 1 comment
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Jul 5, 2024

There are new test failures on [co19] Roll co19 to 67a43c466e367503f19a71a6f2260049698f6c1e.

The tests

co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t18 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t19 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t20 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t21 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t22 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t23 DartkCrash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t23 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t24 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t24 DartkCrash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t25 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t26 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t26 DartkCrash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t17 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t18 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t19 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t20 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t21 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t22 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t22 DartkCrash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t23 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t23 DartkCrash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t24 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t24 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t21 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t22 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t23 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t24 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t26 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t27 Crash (expected Pass)
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A03_t28 Crash (expected Pass)
    and 98 more tests

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-asserts-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
dart2wasm-linux-jscm-chrome
ddc-linux-chrome
vm-mac-debug-arm64
vm-win-release-x64
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Jul 5, 2024
@sgrekhov sgrekhov self-assigned this Jul 5, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 5, 2024
@sgrekhov
Fixes dart-lang#2756. Fix the new roll failures
44367a7
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Jul 5, 2024

Triaged

Failure Issue
analyzer-asserts-linuxnew test -> CompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A04_t26 dart-lang/sdk#56139
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A04_t27 dart-lang/sdk#56139
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A04_t32 dart-lang/sdk#56139
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t20 Fixed
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t22 Fixed
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t24 dart-lang/sdk#56140
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t01 dart-lang/sdk#56142
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t02 dart-lang/sdk#56142
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t12 Fixed
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A05_t24 dart-lang/sdk#56140
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t01 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t02 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t03 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t04 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t05 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t06 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t07 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t08 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t09 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t10 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t11 dart-lang/sdk#56141
co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t13 dart-lang/sdk#56141

@eernstg eernstg closed this as completed in 87c6cbd Jul 5, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 5, 2024
@sgrekhov
Fixes dart-lang#2756. Fix the new roll failures
d61fa0f
eernstg pushed a commit that referenced this issue Jul 5, 2024
@sgrekhov
Fixes #2756. Fix the new roll failures (#2758)
490f1ca
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 8, 2024
@sgrekhov
[co19] Roll co19 to 8dce0f0cf47e9dc1b756b1c1602369842797468a
6d33ca2 
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2759. Update expected errors positions (dart-lang/co19#2760)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2758)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2757)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2754. Fix some of the new roll failures (dart-lang/co19#2755)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add missing `augmented` to operators tests (dart-lang/co19#2753)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. More augmented expressions tests for operators (dart-lang/co19#2752)
2024-07-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2750)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting declarations tests (dart-lang/co19#2565)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2749)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2741. Update expected errors locations in augmenting_types_A07_t10.dart (dart-lang/co19#2747)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2742. Update expected errors locations in augmenting types tests (dart-lang/co19#2748)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2740. Update expected errors locations (dart-lang/co19#2746)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2739. Update expected errors locations (dart-lang/co19#2745)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Fix object identity tests for web platforms (dart-lang/co19#2744)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 in the github-actions group (dart-lang/co19#2743)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Don't expect nan to be identical on web platforms (dart-lang/co19#2737)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2738)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2732. Add missing implementation of an inherited interface (dart-lang/co19#2735)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2733. Expect errors reported on a merged class (dart-lang/co19#2736)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expressions tests (dart-lang/co19#2731)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests (dart-lang/co19#2723)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2726. Update expected errors positions (dart-lang/co19#2727)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2529. Add test checking wildcard parameter with no default value (dart-lang/co19#2730)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2722)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 1 (dart-lang/co19#2724)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 2 (dart-lang/co19#2728)

Change-Id: I86f5bc77bce1c539789132606fa806082afbf7c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374682
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov