-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2726. Update expected errors positions #2727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but one error expectation location seems wrong, so PTAL.
LanguageFeatures/Augmentation-libraries/augmenting_types_A06_t07_lib.dart
Outdated
Show resolved
Hide resolved
Removed. The tests passes on the latest SDK. PTAL |
eernstg
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 8, 2024
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2759. Update expected errors positions (dart-lang/co19#2760) 2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2758) 2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2757) 2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2754. Fix some of the new roll failures (dart-lang/co19#2755) 2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add missing `augmented` to operators tests (dart-lang/co19#2753) 2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. More augmented expressions tests for operators (dart-lang/co19#2752) 2024-07-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2750) 2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting declarations tests (dart-lang/co19#2565) 2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2749) 2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2741. Update expected errors locations in augmenting_types_A07_t10.dart (dart-lang/co19#2747) 2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2742. Update expected errors locations in augmenting types tests (dart-lang/co19#2748) 2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2740. Update expected errors locations (dart-lang/co19#2746) 2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2739. Update expected errors locations (dart-lang/co19#2745) 2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Fix object identity tests for web platforms (dart-lang/co19#2744) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 in the github-actions group (dart-lang/co19#2743) 2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Don't expect nan to be identical on web platforms (dart-lang/co19#2737) 2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2738) 2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2732. Add missing implementation of an inherited interface (dart-lang/co19#2735) 2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2733. Expect errors reported on a merged class (dart-lang/co19#2736) 2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expressions tests (dart-lang/co19#2731) 2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests (dart-lang/co19#2723) 2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2726. Update expected errors positions (dart-lang/co19#2727) 2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2529. Add test checking wildcard parameter with no default value (dart-lang/co19#2730) 2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2722) 2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 1 (dart-lang/co19#2724) 2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 2 (dart-lang/co19#2728) Change-Id: I86f5bc77bce1c539789132606fa806082afbf7c2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374682 Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.