Skip to content

#1430. For HashSet don't run tests that checks iteration order #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2022
Merged

#1430. For HashSet don't run tests that checks iteration order #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df986d3
Fixes #1376. Broken co19_2 test fixed
sgrekhov Jul 26, 2022
95be892
Merge branch 'pre-nnbd' of https://github.com/sgrekhov/co19 into pre-…
sgrekhov Sep 29, 2022
2e1864f
#1430. For HashSet don't run tests that checks iteration order
sgrekhov Sep 29, 2022
0e4cce2
#1430. Revert excessive changes
sgrekhov Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LibTest/collection/HashSet/inherited_tests.lib.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ library inherited_tests_hashset;
import "../../core/Set/all_tests.lib.dart" as set_tests;

test(Set create([Iterable content])) {
set_tests.test(create);
set_tests.test(create, ordered: false);
}
11 changes: 7 additions & 4 deletions LibTest/core/Iterable/allTests.lib.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ import "where_A02_t01.test.dart" as where_A02_t01;
import "where_A03_t01.test.dart" as where_A03_t01;
import "where_A04_t01.test.dart" as where_A04_t01;

test(Iterable create([Iterable content]), {bool isSet:false}) {
test(Iterable create([Iterable content]), {bool isSet = false,
bool ordered = true}) {
any_A01_t01.test(create);
any_A01_t02.test(create);
any_A01_t03.test(create);
any_A01_t04.test(create);
any_A01_t05.test(create);
any_A02_t01.test(create);
contains_A01_t01.test(create);
elementAt_A01_t01.test(create, isSet: isSet);
Expand Down Expand Up @@ -178,10 +178,13 @@ test(Iterable create([Iterable content]), {bool isSet:false}) {
where_A01_t02.test(create);
where_A01_t03.test(create);
where_A01_t05.test(create);
where_A01_t06.test(create);
where_A01_t07.test(create, isSet:isSet);
where_A01_t08.test(create);
where_A02_t01.test(create);
where_A03_t01.test(create);
where_A04_t01.test(create);
if (ordered) {
any_A01_t05.test(create);
where_A01_t06.test(create);
where_A01_t07.test(create, isSet: isSet);
}
}
4 changes: 2 additions & 2 deletions LibTest/core/Set/all_tests.lib.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ import "retainAll_A01_t02.dart" as retainAll_A01_t02;
import "retainWhere_A01_t01.dart" as retainWhere_A01_t01;
import "union_A01_t01.dart" as union_A01_t01;

test(Set create([Iterable content])) {
iterable_tests.test(create, isSet:true);
test(Set create([Iterable content]), {bool ordered = true}) {
iterable_tests.test(create, isSet: true, ordered: ordered);

add_A01_t01.test(create);
add_A01_t02.test(create);
Expand Down