Skip to content

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Sep 29, 2022

co19_2 version. For co19 see #1476

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg
Copy link
Member

eernstg commented Sep 29, 2022

@aam, do you have further comments?

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Oct 10, 2022

@aam, do you have further comments?

I think it was answered in #1476

Copy link
Contributor

@aam aam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry missed this PR

@eernstg eernstg merged commit 65711c0 into dart-lang:pre-nnbd Oct 11, 2022
@sgrekhov sgrekhov deleted the co19_2-1430 branch October 12, 2022 10:14
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 21, 2022
2022-10-20 sgrekhov22@gmail.com dart-lang/co19#1509. Platform.executableArguments added to the tests that run process (dart-lang/co19#1510)
2022-10-11 sgrekhov22@gmail.com dart-lang/co19#1430. For HashSet don't run tests that checks iteration order (dart-lang/co19#1475)

Change-Id: Ia9e2d215a742cf2d8aef5f936ad30decf961528b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265082
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants