#1509. Platform.executableArguments added to the tests that run process #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Oct 20, 2022
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
LGTM.
(Funny formatting we used to have here! ;-)
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 21, 2022
2022-10-20 sgrekhov22@gmail.com dart-lang/co19#1509. Platform.executableArguments added to the tests that run process (dart-lang/co19#1510) 2022-10-11 sgrekhov22@gmail.com dart-lang/co19#1430. For HashSet don't run tests that checks iteration order (dart-lang/co19#1475) Change-Id: Ia9e2d215a742cf2d8aef5f936ad30decf961528b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265082 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.