Fixes #2574. Add more augmenting types tests #2581
Conversation
LanguageFeatures/Augmentation-libraries/augmenting_types_A01_t03_lib.dart
Show resolved
Hide resolved
|
Concluded at the meeting: |
|
Thank you. Fixed |
There was a problem hiding this comment.
I can see in the feature specification that we can do augment e1 in an augment enum declaration in the case where the corresponding enum declaration already has a value named e1.
I do think we should get an error from enum E { e1 } and augment enum E { e1 } (which would include the EAlias case as well).
| } | ||
|
|
||
| augment enum EAlias { | ||
| e1; |
There was a problem hiding this comment.
This is going to be interesting! ;-)
I would expect that this is an error because there is an e1 in E already (so it would fail when we try to add another declaration named e1).
However, the feature specification does use a construct which would be augment e1 in this case, which would then be implied to be OK.
There was a problem hiding this comment.
Changed to augment e1;
2024-04-04 sgrekhov22@gmail.com Fixes dart-lang/co19#2589. Fix roll failure (dart-lang/co19#2590) 2024-04-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting types tests. Augment extends (dart-lang/co19#2588) 2024-04-03 sgrekhov22@gmail.com dart-lang/co19#2559. Rename and regroup augmentation types tests (dart-lang/co19#2587) 2024-04-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 5 (dart-lang/co19#2582) 2024-04-02 sgrekhov22@gmail.com dart-lang/co19#2559. Update augmenting libraries tests according dart-lang/co19#2583 (dart-lang/co19#2586) 2024-04-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2574. Add more augmenting types tests (dart-lang/co19#2581) 2024-04-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 6 (dart-lang/co19#2583) 2024-04-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/co19#2585) 2024-04-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.1.0 to 4.2.1 (dart-lang/co19#2584) 2024-03-27 sgrekhov22@gmail.com Fixes dart-lang/co19#2577. Add more chained patterns assignment tests (dart-lang/co19#2580) 2024-03-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2575. Remove null-aware warnings for CFE (dart-lang/co19#2578) 2024-03-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2576. Replace `library augment` by `augment library` (dart-lang/co19#2579) 2024-03-25 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 2 (dart-lang/co19#2569) R=brianwilkerson@google.com, vegorov@google.com Change-Id: Ibf64d7fdcae0044b7317718ecf7e0852e0983f7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361161 Reviewed-by: Erik Ernst <eernst@google.com> Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Reviewed-by: Alexander Thomas <athom@google.com>
No description provided.