Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementations of Future.then should be updated to use FutureOr #300

Closed
leafpetersen opened this issue Feb 14, 2017 · 1 comment · Fixed by dart-archive/async#27
Closed

Implementations of Future.then should be updated to use FutureOr #300

leafpetersen opened this issue Feb 14, 2017 · 1 comment · Fixed by dart-archive/async#27
Labels
package:async

Comments

@leafpetersen
Copy link
Member

Classes that implement Future should change the signature ot .then to be

then(FutureOr<S> onValue(T x), {Function onError})

to ensure that inference will continue to work for calls to .then and to get better error checking.
@nex3 nex3 mentioned this issue Feb 14, 2017
Merged
nex3 referenced this issue in dart-archive/async Feb 14, 2017
@nex3
Use FutureOr.
cbb157d 
Closes #26
nex3 referenced this issue in dart-archive/async Feb 15, 2017
@nex3
Use FutureOr. (#27)
4c8f9fb 
Closes #26
@leafpetersen
Copy link
Member Author

Thanks!

mosuem referenced this issue Oct 14, 2024
@nex3
Use FutureOr. (dart-archive/async#27)
ce17710 
Closes dart-lang/async#26
@mosuem mosuem transferred this issue from dart-archive/async Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:async
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use FutureOr. dart-archive/async
2 participants
@leafpetersen @mosuem