Skip to content

Move several E2E integration test cases to options_test #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Nov 20, 2023

Some tests in dartdoc_integration_test were flaking on the the Mac bot, timing out. I still have no idea why, but converting them to smaller tests may fix the issue (might be in processing stdout of the external application). If they're still flaky, we can diagnose them better as unit tests.

In moving these test cases, dartdoc_integration_test takes 110 fewer seconds, and options_test takes 2 more seconds.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins mentioned this pull request Nov 20, 2023
1 task
@srawlins srawlins requested a review from kallentu November 21, 2023 00:02
@srawlins srawlins merged commit 6368fcd into dart-lang:main Nov 21, 2023
@srawlins srawlins deleted the move-integration-tests branch November 21, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants