Move several E2E integration test cases to options_test #3585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in
dartdoc_integration_test
were flaking on the the Mac bot, timing out. I still have no idea why, but converting them to smaller tests may fix the issue (might be in processing stdout of the external application). If they're still flaky, we can diagnose them better as unit tests.In moving these test cases,
dartdoc_integration_test
takes 110 fewer seconds, andoptions_test
takes 2 more seconds.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.