Refactor options_test.dart #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallentu
approved these changes
Nov 21, 2023
|
|
||
| test("'format=md' option generates markdown files", () async { | ||
| packagePath = await d.createPackage( | ||
| void test_formatEqualMdOptionGeneratesMarkdownFiles() async { |
There was a problem hiding this comment.
Can we name these more like test_formatOption_md_generatesMarkdownFiles and the one below as test_formatOption_bad_dartDocFailure and the others in a similar fashion where the first test after _ is the option being tested? It's easier to read and categorize :D
There was a problem hiding this comment.
Thanks, great catch! I added some underscores to other test cases after the word Option; nice separation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've moved most tests to use test_reflective_loader for improved reusability. This PR migrates the options_test tests to use test_reflective_loader.
It will merge poorly with #3585 but I can handle the merge when it comes to that. 😄
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.