Allow alert classnames in HTML sanitization. #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @parlough |
|
Note: I have no clue what's going on in test failures, and I also don't have write access to merge this. |
srawlins
reviewed
Jul 15, 2024
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: dartdoc | |||
| version: 8.0.11 | |||
| version: 8.0.12-dev | |||
There was a problem hiding this comment.
When changing this version, 3 other spots need to change:
- CHANGELOG.md (you did)
- dartdoc_options.yaml
- lib/src/version.dart
There was a problem hiding this comment.
Should I use -dev? We use it in pana for intermediate states that precedes release, but keep the final version in changelog. What is the rule here?
There was a problem hiding this comment.
We stick -dev in each of those 4 locations generally. But I can release 8.0.12 right after this is merged so that pub.dev is fixed. So you can use 8.0.12 in each location.
There was a problem hiding this comment.
Please do publish 8.0.12 (not urgent though, just so that we don't forget)
Co-authored-by: Luka S <github@jaffaketchup.dev>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 16, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/f6f93dd..1d00523): 1d005239 2024-07-15 István Soós Allow alert classnames in HTML sanitization. (dart-lang/dartdoc#3820) http (https://github.com/dart-lang/http/compare/edbb5a9..757438e): 757438e 2024-07-16 Kevin Moore Bump pkg:web dependency (dart-lang/http#1272) a6d9f72 2024-07-16 Kevin Moore web_socket: allow latest pkg:web (dart-lang/http#1269) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/8e95ea7..0e1d6e2): 0e1d6e2 2024-07-16 Kevin Moore Support latest pkg:web, prepare release (dart-lang/web_socket_channel#377) Change-Id: I748eb0ac16e5dda2f0b84f44838ed01871b1f4c8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376027 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3819