Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alert classnames in HTML sanitization. #3820

Merged
merged 4 commits into from
Jul 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 8.0.12

* Allow `markdown-alert` class names in HTML sanitization.
isoos marked this conversation as resolved.
Show resolved Hide resolved

## 8.0.11

* Fix the slash key (`/`) not focusing the search box. (#3810)
5 changes: 4 additions & 1 deletion lib/src/render/documentation_renderer.dart
Original file line number Diff line number Diff line change
@@ -77,7 +77,10 @@ class DocumentationRenderResult {
}

bool _allowClassName(String className) =>
className == 'deprecated' || className.startsWith('language-');
className == 'deprecated' ||
className.startsWith('language-') ||
className == 'markdown-alert' ||
className.startsWith('markdown-alert-');

Iterable<String> _addLinkRel(String uriString) {
final uri = Uri.tryParse(uriString);
2 changes: 1 addition & 1 deletion lib/src/version.dart
Original file line number Diff line number Diff line change
@@ -1 +1 @@
const packageVersion = '8.0.11';
const packageVersion = '8.0.12-dev';
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: dartdoc
version: 8.0.11
version: 8.0.12-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing this version, 3 other spots need to change:

  • CHANGELOG.md (you did)
  • dartdoc_options.yaml
  • lib/src/version.dart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use -dev? We use it in pana for intermediate states that precedes release, but keep the final version in changelog. What is the rule here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stick -dev in each of those 4 locations generally. But I can release 8.0.12 right after this is merged so that pub.dev is fixed. So you can use 8.0.12 in each location.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do publish 8.0.12 (not urgent though, just so that we don't forget)

description: A non-interactive HTML documentation generator for Dart source code.
repository: https://github.com/dart-lang/dartdoc