add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment

[devoncarew]

• add invalid_runtime_check_with_js_interop_types
• add unintended_html_in_doc_comment
• prep for publishing

The idea behind this revision is to use the above two lints for a period of time ourselves (these lints are likely going out with the next major revision of package:lints - see https://github.com/orgs/dart-lang/projects/73).

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:dart_flutter_team_lints	3.2.0	ready to publish	dart_flutter_team_lints-v3.2.0
package:firehose	0.9.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[github-actions]

PR Health

Breaking changes ✔️

Details

Package	Change	Current Version	New Version	Needed Version	Looking good?
dart_flutter_team_lints	Breaking	3.1.1-wip	3.2.0	3.2.0	✔️

Changelog Entry ✔️

Details

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details

File	Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

Details

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details

Package	Version	Status
package:dart_flutter_team_lints	3.2.0	ready to publish
package:firehose	0.9.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[parlough]

Two good lints!

[parlough]

I think it's good to add this lint, but I imagine this being in a minor release might break CI for a few repos, as I found quite a few cases of this lint being hit.

That might be a good thing though, as it's almost always indicating an error!

[devoncarew]

I think it's ok to add new lints in a minor version for this package; we've made that call before. It should only break our own repos and we can update as we see failures. It also lets us dogfood earlier - otherwise we'd have to send PRs to each repo to rev the version constraint before we saw the new version.

... as I found quite a few cases of this lint being hit

That's good data - we were wondering how much this would trigger on existing code.

[kevmoo]

Should we add library_name here, too?

[parlough]

Should we add library_name here, too?

I guess you mean unnecessary_library_name? If not publishing a -dev release of lints with it for this package to depend on, I'd say it's a good idea :)

[kevmoo]

@parlough – yes, that's what i mean – @devoncarew ?

[parlough]

Ah the set already has unnecessary_library_name actually :)

ecosystem/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml

Line 37 in f977423

- unnecessary_library_name

[devoncarew]

Yup, already added unnecessary_library_name recently. Landing and will publish this now.