Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment #285

Merged
merged 2 commits into from
Aug 8, 2024
Merged

add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a180d13
add invalid_runtime_check_with_js_interop_types and unintended_html_i…
devoncarew Aug 7, 2024
db16a62
require dart 3.5 for package:dart_flutter_team_lints
devoncarew Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 78 additions & 45 deletions .github/workflows/dart.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pkgs/dart_flutter_team_lints/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## 3.1.1-wip
## 3.2.0

- Contribute a (brief) change policy to the readme.
- Contributed a (brief) change policy to the readme.
- Added `invalid_runtime_check_with_js_interop_types`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to add this lint, but I imagine this being in a minor release might break CI for a few repos, as I found quite a few cases of this lint being hit.

That might be a good thing though, as it's almost always indicating an error!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to add new lints in a minor version for this package; we've made that call before. It should only break our own repos and we can update as we see failures. It also lets us dogfood earlier - otherwise we'd have to send PRs to each repo to rev the version constraint before we saw the new version.

... as I found quite a few cases of this lint being hit

That's good data - we were wondering how much this would trigger on existing code.

- Added `unintended_html_in_doc_comment`.
- Require Dart `3.5`.

## 3.1.0

Expand Down
2 changes: 2 additions & 0 deletions pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@ linter:
- avoid_dynamic_calls
- comment_references
- conditional_uri_does_not_exist
- invalid_runtime_check_with_js_interop_types
- only_throw_errors
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
- unintended_html_in_doc_comment
- unreachable_from_main
4 changes: 2 additions & 2 deletions pkgs/dart_flutter_team_lints/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
version: 3.1.1-wip
version: 3.2.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints

environment:
sdk: ^3.4.0
sdk: ^3.5.0

dependencies:
lints: ^4.0.0
Expand Down
2 changes: 1 addition & 1 deletion tool/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Created with package:mono_repo v6.6.1
# Created with package:mono_repo v6.6.2

# Support built in commands on windows out of the box.

Expand Down