[cfe] Perform checks on factories of extension type declarations

Closes #53209
Closes #53140
Part of #49731

Change-Id: Ia94b1e85d6775efc23bf732441fa66d4de1de515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332403
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

@@ -530,7 +530,8 @@ class KernelTarget extends TargetImplementation {
 
       benchmarker
           ?.enterPhase(BenchmarkPhases.outline_checkRedirectingFactories);
-      loader.checkRedirectingFactories(sortedSourceClassBuilders);
+      loader.checkRedirectingFactories(
+          sortedSourceClassBuilders, sortedSourceExtensionTypeBuilders);
 
       benchmarker
           ?.enterPhase(BenchmarkPhases.outline_finishSynthesizedParameters);

pkg/front_end/lib/src/fasta/source/source_extension_type_declaration_builder.dart

@@ -32,6 +32,7 @@ import '../util/helpers.dart';
 import 'class_declaration.dart';
 import 'source_builder_mixins.dart';
 import 'source_constructor_builder.dart';
+import 'source_factory_builder.dart';
 import 'source_field_builder.dart';
 import 'source_library_builder.dart';
 import 'source_member_builder.dart';
@@ -484,6 +485,15 @@ class SourceExtensionTypeDeclarationBuilder
     }
   }
 
+  void checkRedirectingFactories(TypeEnvironment typeEnvironment) {
+    Iterator<SourceFactoryBuilder> iterator =
+        constructorScope.filteredIterator<SourceFactoryBuilder>(
+            parent: this, includeDuplicates: true, includeAugmentations: true);
+    while (iterator.moveNext()) {
+      iterator.current.checkRedirectingFactories(typeEnvironment);
+    }
+  }
+
   @override
   void buildOutlineExpressions(
       ClassHierarchy classHierarchy,

pkg/front_end/lib/src/fasta/source/source_factory_builder.dart

@@ -336,6 +336,8 @@ class RedirectingFactoryBuilder extends SourceFactoryBuilder {
 
   FreshTypeParameters? _tearOffTypeParameters;
 
+  bool _hasBeenCheckedAsRedirectingFactory = false;
+
   RedirectingFactoryBuilder(
       List<MetadataBuilder>? metadata,
       int modifiers,
@@ -737,6 +739,9 @@ class RedirectingFactoryBuilder extends SourceFactoryBuilder {
 
   @override
   void _checkRedirectingFactory(TypeEnvironment typeEnvironment) {
+    if (_hasBeenCheckedAsRedirectingFactory) return;
+    _hasBeenCheckedAsRedirectingFactory = true;
+
     // Check that factory declaration is not cyclic.
     if (_isCyclicRedirectingFactory(this)) {
       libraryBuilder.addProblemForRedirectingFactory(
@@ -788,6 +793,16 @@ class RedirectingFactoryBuilder extends SourceFactoryBuilder {
       return;
     }
 
+    Builder? redirectionTargetBuilder = redirectionTarget.target;
+    if (redirectionTargetBuilder is RedirectingFactoryBuilder) {
+      redirectionTargetBuilder._checkRedirectingFactory(typeEnvironment);
+      String? errorMessage = redirectionTargetBuilder
+          .function.redirectingFactoryTarget?.errorMessage;
+      if (errorMessage != null) {
+        setRedirectingFactoryError(errorMessage);
+      }
+    }
+
     // Redirection to generative enum constructors is forbidden and is reported
     // as an error elsewhere.
     if (!((classBuilder?.cls.isEnum ?? false) &&

pkg/front_end/lib/src/fasta/source/source_loader.dart

@@ -2774,14 +2774,24 @@ severity: $severity
         .logMs("Updated ${changedClasses.length} classes in kernel hierarchy");
   }
 
-  void checkRedirectingFactories(List<SourceClassBuilder> sourceClasses) {
+  void checkRedirectingFactories(
+      List<SourceClassBuilder> sourceClasses,
+      List<SourceExtensionTypeDeclarationBuilder>
+          sourceExtensionTypeDeclarationBuilders) {
     // TODO(ahe): Move this to [ClassHierarchyBuilder].
     for (SourceClassBuilder builder in sourceClasses) {
       if (builder.libraryBuilder.loader == this && !builder.isPatch) {
         builder.checkRedirectingFactories(
             typeInferenceEngine.typeSchemaEnvironment);
       }
     }
+    for (SourceExtensionTypeDeclarationBuilder builder
+        in sourceExtensionTypeDeclarationBuilders) {
+      if (builder.libraryBuilder.loader == this && !builder.isPatch) {
+        builder.checkRedirectingFactories(
+            typeInferenceEngine.typeSchemaEnvironment);
+      }
+    }
     ticker.logMs("Checked redirecting factories");
   }
 

pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

@@ -248,7 +248,7 @@ class TypeInferrerImpl implements TypeInferrer {
         staticTarget: target);
     visitor.checkCleanState();
     DartType resultType = result.inferredType;
-    if (resultType is InterfaceType) {
+    if (resultType is TypeDeclarationType) {
       return resultType.typeArguments;
     } else {
       return null;

pkg/front_end/test/spell_checking_list_tests.txt

@@ -339,6 +339,7 @@ gave
 gc
 gcd
 gclient
+ge
 gesture
 gi
 gm

pkg/front_end/testcases/dart2js/issue47916e.dart.strong.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916e.dart.strong.transformed.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916e.dart.weak.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916e.dart.weak.modular.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916e.dart.weak.outline.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916e.dart.weak.transformed.expect

@@ -10,9 +10,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A extends core::Object {
-  static factory •() → self::A /* redirection-target: self::B::• */
-    return self::B::•();
-  static method _#new#tearOff() → self::A;
+  static factory •() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
+  static method _#new#tearOff() → self::A
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916e.dart:10:23: Error: Redirection constructor target not found: 'C.named'
+  const factory B() = C.named;
+                      ^";
 }
 abstract class B extends core::Object implements self::A {
   static factory •() → self::B

pkg/front_end/testcases/dart2js/issue47916f.dart.strong.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/dart2js/issue47916f.dart.strong.transformed.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/dart2js/issue47916f.dart.weak.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/dart2js/issue47916f.dart.weak.modular.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/dart2js/issue47916f.dart.weak.outline.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/dart2js/issue47916f.dart.weak.transformed.expect

@@ -14,9 +14,14 @@ import self as self;
 import "dart:core" as core;
 
 abstract class A<T extends core::Object? = dynamic> extends core::Object {
-  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%> /* redirection-target: self::B::•<self::A::•::T%>*/
-    return self::B::•<self::A::•::T%>();
-  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>;
+  static factory •<T extends core::Object? = dynamic>() → self::A<self::A::•::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
+  static method _#new#tearOff<T extends core::Object? = dynamic>() → self::A<self::A::_#new#tearOff::T%>
+    return invalid-expression "pkg/front_end/testcases/dart2js/issue47916f.dart:10:17: Error: Cyclic definition of factory 'B'.
+  const factory B() = C;
+                ^";
 }
 abstract class B<T extends core::Object? = dynamic> extends core::Object implements self::A<self::B::T%> {
   static factory •<T extends core::Object? = dynamic>() → self::B<self::B::•::T%>

pkg/front_end/testcases/extension_types/generic_factory.dart.strong.expect

@@ -24,7 +24,7 @@ static inline-class-member method ET3|constructor#c1<T extends core::num>() →
 }
 static inline-class-member method ET3|constructor#_#c1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#c1#tearOff::T> /* = core::int */
   return self::ET3|constructor#c1<self::ET3|constructor#_#c1#tearOff::T>();
-static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<dynamic>*/
-  return self::ET3|constructor#c1<dynamic>();
+static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<self::ET3|constructor#f1::T>*/
+  return self::ET3|constructor#c1<self::ET3|constructor#f1::T>();
 static inline-class-member method ET3|constructor#_#f1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#f1#tearOff::T> /* = core::int */
-  return self::ET3|constructor#c1<dynamic>();
+  return self::ET3|constructor#c1<self::ET3|constructor#_#f1#tearOff::T>();

pkg/front_end/testcases/extension_types/generic_factory.dart.strong.transformed.expect

@@ -24,13 +24,7 @@ static inline-class-member method ET3|constructor#c1<T extends core::num>() →
 }
 static inline-class-member method ET3|constructor#_#c1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#c1#tearOff::T> /* = core::int */
   return self::ET3|constructor#c1<self::ET3|constructor#_#c1#tearOff::T>();
-static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<dynamic>*/
-  return self::ET3|constructor#c1<dynamic>();
+static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<self::ET3|constructor#f1::T>*/
+  return self::ET3|constructor#c1<self::ET3|constructor#f1::T>();
 static inline-class-member method ET3|constructor#_#f1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#f1#tearOff::T> /* = core::int */
-  return self::ET3|constructor#c1<dynamic>();
-
-
-Extra constant evaluation status:
-Evaluated: StaticInvocation @ org-dartlang-testcase:///generic_factory.dart:7:17 -> IntConstant(0)
-Evaluated: StaticInvocation @ org-dartlang-testcase:///generic_factory.dart:7:11 -> IntConstant(0)
-Extra constant evaluation: evaluated: 10, effectively constant: 2
+  return self::ET3|constructor#c1<self::ET3|constructor#_#f1#tearOff::T>();

pkg/front_end/testcases/extension_types/generic_factory.dart.weak.expect

@@ -24,7 +24,7 @@ static inline-class-member method ET3|constructor#c1<T extends core::num>() →
 }
 static inline-class-member method ET3|constructor#_#c1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#c1#tearOff::T> /* = core::int */
   return self::ET3|constructor#c1<self::ET3|constructor#_#c1#tearOff::T>();
-static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<dynamic>*/
-  return self::ET3|constructor#c1<dynamic>();
+static inline-class-member method ET3|constructor#f1<T extends core::num>() → self::ET3<self::ET3|constructor#f1::T> /* = core::int */ /* redirection-target: self::ET3|constructor#c1<self::ET3|constructor#f1::T>*/
+  return self::ET3|constructor#c1<self::ET3|constructor#f1::T>();
 static inline-class-member method ET3|constructor#_#f1#tearOff<T extends core::num>() → self::ET3<self::ET3|constructor#_#f1#tearOff::T> /* = core::int */
-  return self::ET3|constructor#c1<dynamic>();
+  return self::ET3|constructor#c1<self::ET3|constructor#_#f1#tearOff::T>();