Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extension type] Implement feature in the CFE #49731

Closed
Tracked by #52684
itsjustkevin opened this issue Aug 19, 2022 · 0 comments
Closed
Tracked by #52684

[Extension type] Implement feature in the CFE #49731

itsjustkevin opened this issue Aug 19, 2022 · 0 comments
Assignees
@johnniwinther
Labels
cfe-feature-extension-types Implement extension types feature in the CFE Epic legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@a-siva a-siva added the legacy-area-front-end Legacy: Use area-dart-model instead. label Aug 19, 2022
@johnniwinther johnniwinther changed the title [Views] Implement feature in the CFE [Inline Class] Implement feature in the CFE Jan 19, 2023
@itsjustkevin itsjustkevin changed the title [Inline Class] Implement feature in the CFE [Extension type] Implement feature in the CFE Jul 25, 2023
@itsjustkevin itsjustkevin mentioned this issue Jul 25, 2023
Open
24 tasks
copybara-service bot pushed a commit that referenced this issue Oct 18, 2023
@chloestefantsova
[cfe] Report error on representation type modifiers and missing type
be36f24 
This CL addresses some of the failures reported in
#53074

Part of #49731

Change-Id: I2b23a9d0c095856139563f9e500e88bebadc1ce3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331042
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 18, 2023
@chloestefantsova
[cfe] Report errors on zero or more than one representation fields
ffd43b2 
Part of #49731

Change-Id: I1009241a0a09a92c0e5b22b3848482b87392a72b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331061
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@chloestefantsova
[cfe] Report errors on super formal parameters in extension types
9e36a86 
Closes #53212
Part of #49731

Change-Id: I4f209ab220bb0a47328a60d91e66a891d8fc1362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331048
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@chloestefantsova
[cfe] Report error on bottom type used as representation type
67d4561 
Closes #53824
Part of #49731

Change-Id: I79776eb4f8b736f518898adff1078461895269f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331660
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@chloestefantsova
[cfe] Report error on trailing comma in extension type declarations
75920dd 
Part of #53625
Part of #49731

Change-Id: I793ef6329d99b1a4e829491f454f42c2ede941b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331185
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@chloestefantsova
[cfe] Report contravariant type variable use in extension types
439b79f 
Closes #53803
Part of #49731

Change-Id: I348f6c84aa61eddae306faa96a560b4960724462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331242
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 25, 2023
@chloestefantsova
[cfe] Report error on await of extension type that is not a future
255f260 
Closes #53207
Part of #49731

Change-Id: Idad31c3286108aa3dc75b4b3d7f5364674641582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331980
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 25, 2023
@chloestefantsova
[cfe] Make 'flatten' aware of extension types
b791861 
Part of #49731

Change-Id: Ic7175ebab22f7b9e956030616350e79d1837a1df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331942
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 25, 2023
@chloestefantsova
[cfe] Report an error on optional positional or named parameters in e…
0e2ed5a 
…xtension type declarations

Part of #49731

Change-Id: I49e813f9573b2b66950e8aae572591b65b62e2ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331260
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@chloestefantsova
[cfe] Implement relaxed rule on representation/implemented types
c688bc8 
Closes #53867
Part of #49731

Change-Id: I1a286a8f507e92f85a79acb18d124d3322e1daa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332961
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@chloestefantsova
[cfe] Allow extension types implement Object
dd3705d 
This is a prerequisite to the implementation of
dart-lang/language#3434

Closes #53840
Part of #49731

Change-Id: Ib3bb5961cd8c4919cbc8c8ba37ac4d76fb72a3de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333000
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@chloestefantsova
[cfe] Perform checks on factories of extension type declarations
8b01baa 
Closes #53209
Closes #53140
Part of #49731

Change-Id: Ia94b1e85d6775efc23bf732441fa66d4de1de515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332403
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@chloestefantsova
[cfe] Separate inference and error reporting in super parameters of e…
3c4a74b 
…xtension type constructors

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/331048/comment/fbe89f66_bcf80d94/

Part of #49731

Change-Id: I989cc3d3031e0bc4e66be1e28454443f918d20e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333003
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 2, 2023
@chloestefantsova
[cfe] Include dill in propagating errors in redirecting factories
d003570 
Redirecting factory chains may include a mix of source- and dill-
factory builders. The error propagation should work in that case too.

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/332403/comment/14b70a92_c6e1a91e/

Part of #49731

Change-Id: I74be2a47260c2c24c2fc871b7f1521546f056a03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333162
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
osa1 pushed a commit to osa1/sdk that referenced this issue Nov 3, 2023
@chloestefantsova @osa1
[cfe] Separate inference and error reporting in super parameters of e…
25f6d99 
…xtension type constructors

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/331048/comment/fbe89f66_bcf80d94/

Part of dart-lang#49731

Change-Id: I989cc3d3031e0bc4e66be1e28454443f918d20e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333003
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 6, 2023
@chloestefantsova
[cfe] Ensure reporting all supertype conflicts in extension types
2ea55d4 
Closes #53799
Part of #49731

Change-Id: Ic273541973de6377bb376f51850ec3d7d114c764
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334180
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 7, 2023
@chloestefantsova
[cfe] Report errors on duplicated interfaces in extension types
2b36aff 
Closes #53791
Part of #49731

Change-Id: I41e214c3e2e6339c9b8baeaff727f95dc4089091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334202
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
@johnniwinther johnniwinther added the cfe-feature-extension-types Implement extension types feature in the CFE label Nov 15, 2023
copybara-service bot pushed a commit that referenced this issue Nov 15, 2023
@chloestefantsova
[cfe] Make extension type non-nullable only if it implements Object
c6b0e21 
Part of #49731

TEST=existing

Change-Id: I397bbd5ca7868a9fb344286c910536c6ac341222
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333500
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 27, 2023
@chloestefantsova
[cfe] Type-check new possibilities for rederectee types of Enums
c048054 
With the appearance of extension types one can write programs with
non-trivial subtypes of enum types, making the type checks of targets
of redirection necessary, even if they are generative constructors.

Closes #54010
Part of #49731

Change-Id: Ic415678c6e0579c1acf6f2542ccd90eb24b86362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336886
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 29, 2023
@chloestefantsova
[cfe] Avoid false positives on extension type depending on itself
ff363b5 
Closes #54169
Part of #49731

Change-Id: Ia4a8a2237785b0876461473f98af89b82ccc10eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338601
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 15, 2023
@chloestefantsova
[cfe] Check type variable dependency cycles via extension types
9bb61c0 
Closes #54097
Closes #54164
Part of #49731

Change-Id: I73aac5f7e2c7f05fd0872b37e6f39fa7b5ed4862
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337183
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 15, 2023
@chloestefantsova
Revert "[cfe] Check type variable dependency cycles via extension types"
39e4804 
This reverts commit 9bb61c0.

Reason for revert: NPE detected in google3.

Original change's description:
> [cfe] Check type variable dependency cycles via extension types
>
> Closes #54097
> Closes #54164
> Part of #49731
>
> Change-Id: I73aac5f7e2c7f05fd0872b37e6f39fa7b5ed4862
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337183
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: If1e102112546e333f2e7058e432af142ce7da56e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341922
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 19, 2023
@chloestefantsova
[cfe] Reland "Check type variable dependency cycles via extension types"
a52b9ed 
The original CL: https://dart-review.googlesource.com/c/sdk/+/337183

Closes #54097
Closes #54164
Part of #49731

Change-Id: I3291d17b6edcde87b56ff25d3d99902882100f07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342581
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
cfe-feature-extension-types Implement extension types feature in the CFE Epic legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-siva @itsjustkevin @johnniwinther