Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception from an AST traversal when trying to get dartdoc info for tooltips #2271

Closed
devoncarew opened this issue Mar 23, 2012 · 4 comments
Closed

Exception from an AST traversal when trying to get dartdoc info for tooltips #2271

devoncarew opened this issue Mar 23, 2012 · 4 comments
Assignees
@pq

Comments

@devoncarew
Copy link
Member

When hovering around on this file:

when I hover around on this file:

library('blarg');

import("dart:coreimpl");

source('blah/blob.dart');

I get this exception:

!ENTRY com.google.dart.tools.core 1 0 2012-03-23 11:50:15.254
!MESSAGE INFO: Exception caught while traversing an AST structure. Please report to the dartc team.
!STACK 0
java.lang.UnsupportedOperationException: DartSourceDirective
    at com.google.dart.compiler.ast.DartDirective.getElement(DartDirective.java:15)
    at com.google.dart.tools.core.utilities.ast.DartElementLocator.visitStringLiteral(DartElementLocator.java:478)
    at com.google.dart.tools.core.utilities.ast.DartElementLocator.visitStringLiteral(DartElementLocator.java:1)
    at com.google.dart.compiler.ast.DartStringLiteral.accept(DartStringLiteral.java:32)
    at com.google.dart.compiler.ast.DartSourceDirective.visitChildren(DartSourceDirective.java:23)
    at com.google.dart.tools.core.dom.visitor.ChildVisitor.visitNode(ChildVisitor.java:107)
    at com.google.dart.tools.core.dom.visitor.ChildVisitor.visitNode(ChildVisitor.java:1)
    at com.google.dart.compiler.ast.ASTVisitor.visitDirective(ASTVisitor.java:41)
    at com.google.dart.compiler.ast.ASTVisitor.visitSourceDirective(ASTVisitor.java:269)
    at com.google.dart.compiler.ast.DartSourceDirective.accept(DartSourceDirective.java:28)
    at com.google.dart.tools.core.utilities.ast.DartElementLocator.visitNode(DartElementLocator.java:419)
    at com.google.dart.tools.core.utilities.ast.DartElementLocator.visitNode(DartElementLocator.java:1)
    at com.google.dart.compiler.ast.ASTVisitor.visitDirective(ASTVisitor.java:41)
    at com.google.dart.compiler.ast.ASTVisitor.visitSourceDirective(ASTVisitor.java:269)
    at com.google.dart.compiler.ast.DartSourceDirective.accept(DartSourceDirective.java:28)
    at com.google.dart.compiler.ast.NodeList.accept(NodeList.java:77)
    at com.google.dart.compiler.ast.DartUnit.visitChildren(DartUnit.java:54)
    at com.google.dart.tools.core.dom.visitor.ChildVisitor.visitNode(ChildVisitor.java:107)
    at com.google.dart.tools.core.dom.visitor.ChildVisitor.visitNode(ChildVisitor.java:1)
    at com.google.dart.compiler.ast.ASTVisitor.visitUnit(ASTVisitor.java:317)
    at com.google.dart.compiler.ast.DartUnit.accept(DartUnit.java:61)
    at com.google.dart.tools.core.utilities.ast.DartElementLocator.searchWithin(DartElementLocator.java:237)
    at com.google.dart.tools.core.utilities.dartdoc.DartDocUtilities.getDartDocumentable(DartDocUtilities.java:185)
    at com.google.dart.tools.ui.internal.text.editor.DartTextHover.getHoverInfo(DartTextHover.java:105)
    at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:168)
@DartBot
Copy link

DartBot commented Mar 28, 2012

This comment was originally written by zundel@google.com

On line 478 in DartElementLocator.dart, there is no element for a DartSourceDirective right now because there is no separate DartLibraryUnit compiled. Just grab the string literal and open the file?

@pq
Copy link
Member

pq commented Mar 28, 2012

Removed Area-Compiler label.
Added Area-Editor label.

@pq
Copy link
Member

pq commented Mar 28, 2012

Set owner to @pq.
Added Started label.

@pq
Copy link
Member

pq commented Mar 28, 2012

Fixed: http://codereview.chromium.org/9802036/

Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@devoncarew
[deps] rev lints, mockito, native, protobuf, tools, webdev
4eede85 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

lints (https://github.com/dart-lang/lints/compare/2cf8403..5c60f48):
  5c60f48  2023-10-30  Michael Goderbauer  Update README.md to use new syntax for adding dev dependencies (#167)

mockito (https://github.com/dart-lang/mockito/compare/4edf86f..b7d752e):
  b7d752e  2023-10-26  Ilya Yanok  Use Dart SDK 3.1.0 for format check
  ca537db  2023-10-26  Ilya Yanok  Remove unneeded deprecation warning disable comment
  1a0d0e7  2023-10-26  Ilya Yanok  Remove deprecated `returnNullOnMissingStub` and `OnMissingStub.returnNull`

native (https://github.com/dart-lang/native/compare/757f503..279094d):
  279094d  2023-10-30  Pierrick Bouvier  [native_toolchain_c] Support MSVC arm64 toolchain (#167)
  9629a55  2023-10-27  Parker Lougheed  Allow modification of a BuildOutput's raw dependencies (#169)
  762b4da  2023-10-27  Ryan Macnak  [native_assets_cli] Add Android RISCV64 target. (#166)
  18bff8c  2023-10-25  Ryan Macnak  [native_toolchain_c] Setup Linux X64 toolchain for non-X64 hosts. (#164)
  d79a7cd  2023-10-25  Ryan Macnak  [native_toolchain_c] Setup Linux RISCV64 toolchain. (#163)
  ce26f75  2023-10-25  Parker Lougheed  Update all lints and dart_flutter_team_lints dependencies (#161)

protobuf (https://github.com/dart-lang/protobuf/compare/3528fad..3f567b2):
  3f567b2  2023-10-27  Ömer Sinan Ağacan  Remove the dynamic call in `CodedBufferWriter` (#895)
  42436cd  2023-10-26  Ömer Sinan Ağacan  Keep a `ByteData` around in `CodedBufferReader` to avoid repeated `ByteData` allocs (#890)
  9a73936  2023-10-26  Ömer Sinan Ağacan  Avoid adding empty splices in `CodedBufferWriter` (#886)
  23dffde  2023-10-26  Ömer Sinan Ağacan  Update a bug link in a comment (#892)
  19903f0  2023-10-26  Ömer Sinan Ağacan  Make `CodedBufferWriter.writeRawByte` argument type more accurate (#891)
  2ce3e14  2023-10-26  Ömer Sinan Ağacan  Update `FieldInfo._ensureRepeatedField` return type (#893)
  e146515  2023-10-25  Ömer Sinan Ağacan  Avoid redundant ByteData allocation when decoding sfixed64 (#889)
  1b1d549  2023-10-25  Ömer Sinan Ağacan  Avoid allocating temporary views in when decoding strings in `CodedBufferReader` (#888)

tools (https://github.com/dart-lang/tools/compare/da6bb18..e828d45):
  e828d45  2023-10-27  Elias Yishak  Create tests for each event constructor (#186)

webdev (https://github.com/dart-lang/webdev/compare/25f17cd..50534a1):
  50534a12  2023-10-30  Elliott Brooks  Cider passes an app ID instead of a workspace name to connect to the Dart Debug Extension (#2272)
  b3d6ef14  2023-10-27  Elliott Brooks  Expose a keyboard shortcut to copy the Dart app ID (#2271)
  c26b4e5f  2023-10-27  Elliott Brooks  Reset Webdev to 3.3.0-wip after release (#2269)
  982b955b  2023-10-26  Elliott Brooks  Prepare webdev for 3.2.0  (#2268)
  62361fbf  2023-10-26  Elliott Brooks  Reset DWDS after release (#2267)
  50b8ae86  2023-10-26  Elliott Brooks  Prepare DWDS for release to version 22.1.0 (#2266)

Change-Id: Ia02db3bc66bac55b637ed5e173fe5c5d50bcca52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332748
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @devoncarew @DartBot