Bug in DartCombat code #169
Assignees
Labels
area-samples (deprecated)
Deprecated: this label is no longer actively used.
closed-not-planned
Closed as we don't intend to take action on the reported issue
Comments
|
This comment was originally written by drfibonacci@google.com Added Area-Samples, Triaged labels. |
|
Set owner to @sigmundch. |
|
marking as obsolete, we plan to delete this sample soon. Added WontFix label. |
DartBot
added
Type-Defect
area-samples (deprecated)
kevmoo
added
closed-not-planned
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
May 24, 2022
Merges shelf_router and shelf_router_generator to the shelf mono repo. Changes: ``` > git log --format="%C(auto) %h %s" fadca32..05f4260 https://dart.googlesource.com/shelf.git/+/05f4260 Merge remote-tracking branch 'origin/HEAD' into jonasfj/master https://dart.googlesource.com/shelf.git/+/4f4fa0a Fix pubspec repository for shelf_web_socket (#233) https://dart.googlesource.com/shelf.git/+/d4ff2ae Update READMEs, adjust mono_pkg.yaml https://dart.googlesource.com/shelf.git/+/d6efa6e Merge in shelf_router / shelf_router_generator. https://dart.googlesource.com/shelf.git/+/6d1f24d Add root readme (#229) https://dart.googlesource.com/shelf.git/+/d23cc89 Use the same lints across all packages (#228) https://dart.googlesource.com/shelf.git/+/3fdddb1 Merge CI steps across packages (#226) https://dart.googlesource.com/shelf.git/+/9b5a08a Upgrade mono_repo (#174) https://dart.googlesource.com/shelf.git/+/f04e60f Upgrade mono_repo (#169) https://dart.googlesource.com/shelf.git/+/ef1c1ae Merge pull request #165 from isoos/upgrade https://dart.googlesource.com/shelf.git/+/dc49716 bump version https://dart.googlesource.com/shelf.git/+/07bf70a Upgrade dependencies in shelf_router_generator https://dart.googlesource.com/shelf.git/+/640915e fix: mount remove trailing slash requirement (#146) https://dart.googlesource.com/shelf.git/+/138ca19 Migrate to pkg:lints (#161) https://dart.googlesource.com/shelf.git/+/d2d026b Bump mono_repo to v5.0.1 (#150) https://dart.googlesource.com/shelf.git/+/ac19cc9 Fix a number of hints and lints (#151) https://dart.googlesource.com/shelf.git/+/9cb612a shelf_router_generator: latest dependencies (#152) https://dart.googlesource.com/shelf.git/+/4947570 Fix SDK constraints 2.12.0-0 to 2.12.0 (#148) https://dart.googlesource.com/shelf.git/+/8a11fee Merge pull request #147 from isoos/fix-rnf https://dart.googlesource.com/shelf.git/+/789824d Fix Router.routeNotFound to enable multiple read() calls on it. https://dart.googlesource.com/shelf.git/+/fac496f Introduce `routeNotFound` sentinel for shelf_router 1.1.0 (#141) https://dart.googlesource.com/shelf.git/+/33206e9 remove handler from app (#131) https://dart.googlesource.com/shelf.git/+/02c49f7 remove handler from app (#129) https://dart.googlesource.com/shelf.git/+/12cd917 shelf_router_generator: Latest dependencies, null safety (#122) https://dart.googlesource.com/shelf.git/+/074341b Update dependencies and enable/fix a number of lints (#120) https://dart.googlesource.com/shelf.git/+/b094c25 shelf_router_generator: Support null-safe dependencies (#113) https://dart.googlesource.com/shelf.git/+/f07b3ef Prepare shelf_router 1.0.0 https://dart.googlesource.com/shelf.git/+/4c73784 Remove Router.handler while we're at it https://dart.googlesource.com/shelf.git/+/b18f808 Remove checkNotNull https://dart.googlesource.com/shelf.git/+/cce2ad9 Oops, forgot to set _params https://dart.googlesource.com/shelf.git/+/797da6e Avoid lazy in router entry https://dart.googlesource.com/shelf.git/+/a03e120 Make default handler customizable https://dart.googlesource.com/shelf.git/+/ed942ce No unecessary version bump, don't test on stable https://dart.googlesource.com/shelf.git/+/e18b186 [WIP] Migrate shelf_router to Dart null safety https://dart.googlesource.com/shelf.git/+/2a7cdd5 Upgrade package:analyzer in shelf_router_generator. https://dart.googlesource.com/shelf.git/+/6466748 Router: allow to mount a Handler (#86) https://dart.googlesource.com/shelf.git/+/91b695d Seal classes in shelf_router and prepare 0.7.3 (#85) https://dart.googlesource.com/shelf.git/+/4b4f15c Fix most of the hints - thanks to `dart fix` (#81) https://dart.googlesource.com/shelf.git/+/e99bcd0 Relax dependency constraint on analyzer for shelf_router_generator. (#79) https://dart.googlesource.com/shelf.git/+/2893dab Remove author from pubspec.yaml (#73) https://dart.googlesource.com/shelf.git/+/ac41ee2 Updated Travis configuration to allow packages to be tested in parallel jobs (#59) https://dart.googlesource.com/shelf.git/+/ad11925 Fix package:shelf_router to ensure GET handlers also respond to HEAD requests (#36) https://dart.googlesource.com/shelf.git/+/6a07835 Relax dependency on package:analyzer https://dart.googlesource.com/shelf.git/+/02e05dc Merge pull request #27 from jonasfj/relax-deps https://dart.googlesource.com/shelf.git/+/84fdb64 relax dependency constraint on analyzer https://dart.googlesource.com/shelf.git/+/aea3117 Merge pull request #19 from jonasfj/test-unrelated-annotation https://dart.googlesource.com/shelf.git/+/563e435 Test that unrelated annotations does not affect code-gen https://dart.googlesource.com/shelf.git/+/213d63a Prepare for releasing 0.7.2 https://dart.googlesource.com/shelf.git/+/910173d Add generated files https://dart.googlesource.com/shelf.git/+/d0e21d5 Added test case for string escaping https://dart.googlesource.com/shelf.git/+/663de80 Fix issue #10, use raw strings https://dart.googlesource.com/shelf.git/+/3a9cd9f Fix travis tests https://dart.googlesource.com/shelf.git/+/c7c3baf Use Function instead of dynamic for handler in shelf_router https://dart.googlesource.com/shelf.git/+/592fd64 Fixed #6, using Function instead of dynamic https://dart.googlesource.com/shelf.git/+/26e888f Bumped shelf_router_generator dependencies https://dart.googlesource.com/shelf.git/+/7622006 Updated shelf_router_generator README https://dart.googlesource.com/shelf.git/+/3aa13ea Fixing nits for shelf-router https://dart.googlesource.com/shelf.git/+/279af5d Prepared shelf_router_generator for initial release https://dart.googlesource.com/shelf.git/+/eb39128 Removed dependency overrides from shelf_router, and updated changelog https://dart.googlesource.com/shelf.git/+/8baca2f Added authors and tool for publishing packages https://dart.googlesource.com/shelf.git/+/9d9d82c Added packages shelf_router and shelf_router_generator ``` Diff: https://dart.googlesource.com/shelf.git/+/fadca320b04689be9ec960013843a0d9ee6c4fc4~..05f42601d22c9bfe490ceda50e812f83b7d1de77/ Change-Id: Icb576d2a6005a036963508c7e32a65752dfb3033 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245903 Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Nate Bosch <nbosch@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com> Commit-Queue: Kevin Moore <kevmoo@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 10, 2023
…ed_data, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. csslib (https://github.com/dart-lang/csslib/compare/923edf0..c4e904c): c4e904c 2023-05-10 Devon Carew rev for publishing (#179) c9e47d0 2023-05-10 Kevin Moore Require Dart 2.19, latest lints, skin hanging test (#175) 3976e6f 2023-05-10 Devon Carew address an issue parsing font names (#168) a337a9a 2023-05-10 Devon Carew fixed CssPrinter pretty print indent levels (#169) ffi (https://github.com/dart-lang/ffi/compare/1a859e0..7f4acbd): 7f4acbd 2023-05-09 Devon Carew Rev pubspec and update changelog (#194) http (https://github.com/dart-lang/http/compare/406ce74..db84d12): db84d12 2023-05-10 Brian Quinlan Require the release version of Dart 3.0.0 (#925) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/fc14e36..46a1fa0): 46a1fa0 2023-05-09 Polina Cherkasova Make sure leak tracker does not fail in case of duplicates. (#60) mime (https://github.com/dart-lang/mime/compare/cd8001e..57fbf6e): 57fbf6e 2023-05-09 Dimitar Petrov Add m4b mime type (#92) protobuf (https://github.com/dart-lang/protobuf/compare/9d7cf0d..05058a7): 05058a7 2023-05-10 Ömer Sinan Ağacan Apply internally enabled lints (#816) test (https://github.com/dart-lang/test/compare/1d65501..0b306dd): 0b306dd5 2023-05-09 Nate Bosch Document behavior of explicit file path args (#2011) typed_data (https://github.com/dart-lang/typed_data/compare/021f25a..921f5c0): 921f5c0 2023-05-09 Devon Carew add topics to the pubspec file (#65) webdev (https://github.com/dart-lang/webdev/compare/fe5b975..469b105): 469b1058 2023-05-10 Elliott Brooks Update DCM workflow (#2106) yaml (https://github.com/dart-lang/yaml/compare/1f39ffe..af3d8cd): af3d8cd 2023-05-10 Nate Bosch Uncomment some tests (#145) Change-Id: I97a7b284e01c4fde10b8cfc814d95ecc9686ddff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302448 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 19, 2023
…, http_parser, leak_tracker, logging, markdown, matcher, mockito, shelf, source_map_stack_trace, tools Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/d744058..96c29d0): 96c29d0 2023-05-17 Goddchen docs: fix typo in CancelableOperation.fromFuture(...) docs (#243) csslib (https://github.com/dart-lang/csslib/compare/923edf0..b2b9b55): b2b9b55 2023-05-18 Devon Carew address a regression in the compact output format (#183) 1ff82fd 2023-05-15 Devon Carew blast_repo fixes (#181) 35bef7f 2023-05-11 Nate Bosch Simplify TopLevelIncludes visitor (#180) c4e904c 2023-05-10 Devon Carew rev for publishing (#179) c9e47d0 2023-05-10 Kevin Moore Require Dart 2.19, latest lints, skin hanging test (#175) 3976e6f 2023-05-10 Devon Carew address an issue parsing font names (#168) a337a9a 2023-05-10 Devon Carew fixed CssPrinter pretty print indent levels (#169) fixnum (https://github.com/dart-lang/fixnum/compare/006a130..d9b9a2a): d9b9a2a 2023-05-17 Devon Carew blast_repo fixes (#112) glob (https://github.com/dart-lang/glob/compare/46403be..30f6aba): 30f6aba 2023-05-17 Devon Carew blast_repo fixes (#77) html (https://github.com/dart-lang/html/compare/593d6f6..92eacab): 92eacab 2023-05-17 Devon Carew blast_repo fixes (#216) http (https://github.com/dart-lang/http/compare/fb3b4be..d845560): d845560 2023-05-17 Devon Carew blast_repo fixes (#933) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/d1fffed..a209cd5): a209cd5 2023-05-17 Devon Carew blast_repo fixes (#55) http_parser (https://github.com/dart-lang/http_parser/compare/5a33f5f..1ef3e56): 1ef3e56 2023-05-17 Devon Carew blast_repo fixes (#73) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/8ae200a..571c24a): 571c24a 2023-05-18 Polina Cherkasova Delete generate_diagrams.yaml (#67) f2029b6 2023-05-18 Devon Carew blast_repo fixes (#66) 474fd4f 2023-05-18 Polina Cherkasova Separate testing. (#65) 92a0b48 2023-05-17 Polina Cherkasova Fixes to support G3. (#64) logging (https://github.com/dart-lang/logging/compare/b75cba7..fa2486d): fa2486d 2023-05-18 Desislava Stefanova Logger `onLevelChanged` notification (#138) markdown (https://github.com/dart-lang/markdown/compare/6db8fc1..b951454): b951454 2023-05-18 Devon Carew blast_repo fixes (#542) a714d95 2023-05-17 Zhiguang Chen Fix delimiter row matching pattern for tables (#540) matcher (https://github.com/dart-lang/matcher/compare/4dfd9ad..7e10117): 7e10117 2023-05-18 Devon Carew blast_repo fixes (#224) mockito (https://github.com/dart-lang/mockito/compare/3fadd2d..28f174f): 28f174f 2023-05-17 Ilya Yanok Only check formatting with the stable SDK shelf (https://github.com/dart-lang/shelf/compare/79e3cee..8793687): 8793687 2023-05-18 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#353) 2f1aefb 2023-05-18 Devon Carew blast_repo fixes (#351) e1ca05d 2023-05-18 Devon Carew Update no-response.yml (#349) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/09715f9..b83af01): b83af01 2023-05-18 Devon Carew blast_repo fixes (#39) tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) Change-Id: I5cd1277e6df1d72f69569090d9a2381a2b81d5d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304460 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 19, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/babf5d1..ed39318): ed39318 2023-09-14 Devon Carew validate a prerelease setup-dart version (#169) b3dc96f 2023-09-14 Devon Carew fix an issue rendering multi-line changelogs (#171) http (https://github.com/dart-lang/http/compare/e19094a..decefa6): decefa6 2023-09-15 Brian Quinlan Remove invalid status line tests and replace them with valid status line tests (#1018) native (https://github.com/dart-lang/native/compare/4f4d7c3..a5d8809): a5d8809 2023-09-18 Daco Harkes [native_toolchain_c] Bump version (#140) tools (https://github.com/dart-lang/tools/compare/1512f3d..63d8267): 63d8267 2023-09-18 Elias Yishak Restrict surveys for certain tools (#161) 5a1fc54 2023-09-14 Devon Carew validate a pre-release setup-dart action (#160) webdev (https://github.com/dart-lang/webdev/compare/501ccc2..d7e0d1f): d7e0d1ff 2023-09-15 Devon Carew test the latest setup-dart action (#2233) 4e231bc3 2023-09-14 Elliott Brooks Fix copying over `client.dart.js` to `client.js` when build DWDS (#2232) Change-Id: Iac8741aed14591402b1c8a3cd33dc00e4648ac0c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326720 Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 4, 2023
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5a4e16f..df9b428): df9b428 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#256) 892f013 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#257) async (https://github.com/dart-lang/async/compare/75efa6c..def4482): def4482 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#253) a0ca552 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#252) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/159e671..b1b6a66): b1b6a66 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#82) bb9e48d 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#81) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/7d0d28e..59aea95): 59aea95 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#94) e3f6207 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#93) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/f255921..9431e01): 9431e01 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#51) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/1f69393..25bc94a): 25bc94a 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#50) cli_util (https://github.com/dart-lang/cli_util/compare/44118e3..9e48f0d): 9e48f0d 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#90) clock (https://github.com/dart-lang/clock/compare/1e75f08..200a020): 200a020 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#56) 8a2b550 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#57) collection (https://github.com/dart-lang/collection/compare/91afde4..d27bfaf): d27bfaf 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#314) 5d568ae 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#313) convert (https://github.com/dart-lang/convert/compare/c058c8f..140b2f0): 140b2f0 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#87) crypto (https://github.com/dart-lang/crypto/compare/1e26879..b38dd62): b38dd62 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153) csslib (https://github.com/dart-lang/csslib/compare/bd30a1a..f6b68dd): f6b68dd 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#190) 4b1ee3f 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#189) dartdoc (https://github.com/dart-lang/dartdoc/compare/a3cfdc4..59947b1): 59947b14 2023-09-25 Sam Rawlins Do not hide stacktrace of DartdocFailures (#3505) d95af5c7 2023-09-25 dependabot[bot] Bump actions/checkout from 4.0.0 to 4.1.0 (#3506) ecosystem (https://github.com/dart-lang/ecosystem/compare/3da2dd3..dcbd2ee): dcbd2ee 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#184) 3006120 2023-10-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#183) 69334aa 2023-10-01 dependabot[bot] Bump actions/upload-artifact (#181) 3dd6c69 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#185) 2c5523c 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#182) 5b7d3fd 2023-09-28 Devon Carew update package:dart_flutter_team_lints to use the beta package:lints (#179) 297e63e 2023-09-28 Devon Carew fix an issue validating pre-release git publishing tags (#180) 1154183 2023-09-28 Moritz Check for `DO_NOT_SUBMIT` strings. (#178) bc2dd27 2023-09-28 Moritz Add api tool call for testing (#153) eb8e398 2023-09-27 Moritz Do not fail `publish` on forks (#177) f40a4eb 2023-09-25 Devon Carew improve support for '-dev' and '-wip' package versions (#173) ffi (https://github.com/dart-lang/ffi/compare/d36e05a..ee70dd4): ee70dd4 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#214) fixnum (https://github.com/dart-lang/fixnum/compare/87ed065..ef0a587): ef0a587 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#115) glob (https://github.com/dart-lang/glob/compare/9c1996f..0046533): 0046533 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#83) f6ebc74 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#84) html (https://github.com/dart-lang/html/compare/a1b193e..49e2c8e): 49e2c8e 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#228) fb2de8a 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#227) http (https://github.com/dart-lang/http/compare/1251619..88ec75e): 88ec75e 2023-10-01 dependabot[bot] Bump actions/checkout from 3 to 4 (#1025) 08143d1 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#1024) 2c99da1 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#1023) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/9d62ea3..03041aa): 03041aa 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#59) 5efaa07 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#58) http_parser (https://github.com/dart-lang/http_parser/compare/d2d03e7..c557f57): c557f57 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#78) a629fd6 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#79) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/50a3786..0521afb): 0521afb 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#104) 4782145 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103) lints (https://github.com/dart-lang/lints/compare/b044aca..140c802): 140c802 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#158) 624a09d 2023-09-28 Devon Carew add dangling_library_doc_comments, remove prefer_void_to_null (#157) 296efaf 2023-09-28 Devon Carew remove no_wildcard_variable_uses; improve testing (#156) c266a04 2023-09-26 Devon Carew rev to 3.0.0-beta in preparation for publishing (#153) logging (https://github.com/dart-lang/logging/compare/bcaad0f..642ed21): 642ed21 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#149) 287f4cb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#148) markdown (https://github.com/dart-lang/markdown/compare/6cfd6f1..ae766d5): ae766d5 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#556) matcher (https://github.com/dart-lang/matcher/compare/80910d6..11daad9): 11daad9 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#229) mime (https://github.com/dart-lang/mime/compare/37ef637..f3b9c49): f3b9c49 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#105) mockito (https://github.com/dart-lang/mockito/compare/097e563..610c3dc): 610c3dc 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#699) 73930cd 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#698) native (https://github.com/dart-lang/native/compare/be4aaf7..22500ea): 22500ea 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#144) 5bfc7ff 2023-10-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#145) 0b7885a 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#143) package_config (https://github.com/dart-lang/package_config/compare/ae7ad83..100533d): 100533d 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#141) a4b474a 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#142) path (https://github.com/dart-lang/path/compare/96d9183..abcf38c): abcf38c 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#151) pool (https://github.com/dart-lang/pool/compare/a5bee35..4bcc7de): 4bcc7de 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#75) pub_semver (https://github.com/dart-lang/pub_semver/compare/f0be74a..8e5a58f): 8e5a58f 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#93) 81da7c8 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#92) shelf (https://github.com/dart-lang/shelf/compare/4851978..c15fc6f): c15fc6f 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#386) e47c00e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#384) b9c898e 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#385) 9b96b9b 2023-09-26 Michael Thomsen Add backend tag in pubspec.yaml (#381) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/196d7bf..73d449c): 73d449c 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#42) 2c4840e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#43) source_maps (https://github.com/dart-lang/source_maps/compare/eb3d40a..fc6aa16): fc6aa16 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#83) dfca7d5 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#82) source_span (https://github.com/dart-lang/source_span/compare/48d0f57..92e50bf): 92e50bf 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#102) c212afa 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103) sse (https://github.com/dart-lang/sse/compare/eeb2588..606387e): 606387e 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#89) stack_trace (https://github.com/dart-lang/stack_trace/compare/bcf2a0b..1c36cd7): 1c36cd7 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#143) stream_channel (https://github.com/dart-lang/stream_channel/compare/0ce7ab6..bf74065): bf74065 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#95) string_scanner (https://github.com/dart-lang/string_scanner/compare/da9142c..616424c): 616424c 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#63) term_glyph (https://github.com/dart-lang/term_glyph/compare/1b28285..19abf84): 19abf84 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#42) test (https://github.com/dart-lang/test/compare/8191a35..367aa39): 367aa397 2023-10-02 Jacob MacDonald release test_core and test (#2112) 672be9d7 2023-10-02 Ben Konyi Update package:vm_service to 12.0.0 (#2110) de324cc7 2023-10-01 dependabot[bot] Bump github/codeql-action from 2.21.5 to 2.21.9 (#2106) 31b94dbb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#2105) d56c2150 2023-10-01 dependabot[bot] Bump actions/cache from 3.0.11 to 3.3.2 (#2108) b93f1b50 2023-10-01 dependabot[bot] Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#2109) a077b673 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#2107) 566d70a2 2023-09-26 Lau Ching Jun Filter test by line when kernel is compiled with --filesystem-scheme. (#2101) 7ec1bbf5 2023-09-25 Nate Bosch Drop support for legacy iframe communication (#2099) d3f4b368 2023-09-25 Nate Bosch Tighten types in test utils (#2097) 9d997910 2023-09-25 Nate Bosch Add types to Browser implementation url arguments (#2096) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/030193d..55b5eac): 55b5eac 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#57) c2ba59e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#56) test_process (https://github.com/dart-lang/test_process/compare/2a6ee23..5efd0bf): 5efd0bf 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#49) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/45c57d6..8593eb1): 8593eb1 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#52) 4857e22 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#53) tools (https://github.com/dart-lang/tools/compare/3c248df..f318c80): f318c80 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#177) 0480655 2023-10-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#176) 73583e8 2023-09-29 Devon Carew update package:cli_config to the latest package:dart_flutter_team_lints (#171) b293897 2023-09-28 Devon Carew update to the latest package:dart_flutter_team_lints (#173) 242fdb5 2023-09-28 Devon Carew update to the latest package:dart_flutter_team_lints (#172) a51f779 2023-09-28 Elias Yishak Use constant for no op client id (#168) e83caee 2023-09-27 Moritz Allow `publish` to write comments on forks (#169) typed_data (https://github.com/dart-lang/typed_data/compare/80e8943..d1c15ed): d1c15ed 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#73) e13af06 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#74) usage (https://github.com/dart-lang/usage/compare/7b12d51..d7d2964): d7d2964 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#198) 920c6e8 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#199) watcher (https://github.com/dart-lang/watcher/compare/1aed03e..c480e2d): c480e2d 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#151) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af945f1..364013d): 364013d 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#286) 50dada7 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#285) webdev (https://github.com/dart-lang/webdev/compare/3078f48..7c2c2d7): 7c2c2d70 2023-10-01 dependabot[bot] Bump actions/checkout from 3.2.0 to 4.1.0 (#2245) 7739a114 2023-09-26 Elliott Brooks Refactor tests to handle new `ToolConfiguration` (#2243) 4e350cde 2023-09-21 Elliott Brooks Fix issue with the inspector panel in the Dart Debug Extension (#2242) bbddba29 2023-09-21 Elliott Brooks Prepare the Dart Debug Extension for release to version 1.36 (#2241) cc5db13f 2023-09-21 Elliott Brooks Rename plainUri to debugUri and send it to the extension (#2238) 48fc725f 2023-09-20 Elliott Brooks Add a new workspaceName parameter to DWDS on start up (#2237) d2dae560 2023-09-20 Elliott Brooks Refactor: Update the parameters for `DWDS.start` (#2231) yaml (https://github.com/dart-lang/yaml/compare/ae00187..9f0d649): 9f0d649 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153) 8e70ffb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#152) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/4a9734d..a7e7fba): a7e7fba 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#58) f33e3d0 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#59) 8a380e8 2023-09-28 Sigurd Meldgaard Change AliasError to AliasException (#57) Change-Id: I22f88e36d2eceb03495dabcf1265e9043364e0bd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329260 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 31, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. lints (https://github.com/dart-lang/lints/compare/2cf8403..5c60f48): 5c60f48 2023-10-30 Michael Goderbauer Update README.md to use new syntax for adding dev dependencies (#167) mockito (https://github.com/dart-lang/mockito/compare/4edf86f..b7d752e): b7d752e 2023-10-26 Ilya Yanok Use Dart SDK 3.1.0 for format check ca537db 2023-10-26 Ilya Yanok Remove unneeded deprecation warning disable comment 1a0d0e7 2023-10-26 Ilya Yanok Remove deprecated `returnNullOnMissingStub` and `OnMissingStub.returnNull` native (https://github.com/dart-lang/native/compare/757f503..279094d): 279094d 2023-10-30 Pierrick Bouvier [native_toolchain_c] Support MSVC arm64 toolchain (#167) 9629a55 2023-10-27 Parker Lougheed Allow modification of a BuildOutput's raw dependencies (#169) 762b4da 2023-10-27 Ryan Macnak [native_assets_cli] Add Android RISCV64 target. (#166) 18bff8c 2023-10-25 Ryan Macnak [native_toolchain_c] Setup Linux X64 toolchain for non-X64 hosts. (#164) d79a7cd 2023-10-25 Ryan Macnak [native_toolchain_c] Setup Linux RISCV64 toolchain. (#163) ce26f75 2023-10-25 Parker Lougheed Update all lints and dart_flutter_team_lints dependencies (#161) protobuf (https://github.com/dart-lang/protobuf/compare/3528fad..3f567b2): 3f567b2 2023-10-27 Ömer Sinan Ağacan Remove the dynamic call in `CodedBufferWriter` (#895) 42436cd 2023-10-26 Ömer Sinan Ağacan Keep a `ByteData` around in `CodedBufferReader` to avoid repeated `ByteData` allocs (#890) 9a73936 2023-10-26 Ömer Sinan Ağacan Avoid adding empty splices in `CodedBufferWriter` (#886) 23dffde 2023-10-26 Ömer Sinan Ağacan Update a bug link in a comment (#892) 19903f0 2023-10-26 Ömer Sinan Ağacan Make `CodedBufferWriter.writeRawByte` argument type more accurate (#891) 2ce3e14 2023-10-26 Ömer Sinan Ağacan Update `FieldInfo._ensureRepeatedField` return type (#893) e146515 2023-10-25 Ömer Sinan Ağacan Avoid redundant ByteData allocation when decoding sfixed64 (#889) 1b1d549 2023-10-25 Ömer Sinan Ağacan Avoid allocating temporary views in when decoding strings in `CodedBufferReader` (#888) tools (https://github.com/dart-lang/tools/compare/da6bb18..e828d45): e828d45 2023-10-27 Elias Yishak Create tests for each event constructor (#186) webdev (https://github.com/dart-lang/webdev/compare/25f17cd..50534a1): 50534a12 2023-10-30 Elliott Brooks Cider passes an app ID instead of a workspace name to connect to the Dart Debug Extension (#2272) b3d6ef14 2023-10-27 Elliott Brooks Expose a keyboard shortcut to copy the Dart app ID (#2271) c26b4e5f 2023-10-27 Elliott Brooks Reset Webdev to 3.3.0-wip after release (#2269) 982b955b 2023-10-26 Elliott Brooks Prepare webdev for 3.2.0 (#2268) 62361fbf 2023-10-26 Elliott Brooks Reset DWDS after release (#2267) 50b8ae86 2023-10-26 Elliott Brooks Prepare DWDS for release to version 22.1.0 (#2266) Change-Id: Ia02db3bc66bac55b637ed5e173fe5c5d50bcca52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332748 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by frederic.d...@gmail.com
What steps will reproduce the problem?
1.Run Dartcombat
2.Align 4boats vertically
3.Cross all the boats with one more
4.Shoot the first square of the horizontal boats
5. click on all the other boats
What is the expected output? What do you see instead?
The expected output is a total count of 5 sunk boats, instead of that, only the 1st boat is taken into account
What version of the product are you using? On what operating system?
Please provide any additional information below.
Attachment:
dartCombatBug.bmp (3.75 MB)
The text was updated successfully, but these errors were encountered: