Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String interpolation problem #2595

Closed
clayberg opened this issue Apr 16, 2012 · 2 comments
Closed

String interpolation problem #2595

clayberg opened this issue Apr 16, 2012 · 2 comments
Assignees
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@clayberg
Copy link

[user feedback]

Little string interpolation problem...
Take a look at screenshot: http://i.imm.io/m3RY.png
The string is marked as error in the editor, but it runs well.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 6528
////////////////////////////////////////////////////////////////////////////////////
OS: Windows 7 - amd64 (6.1)
SDK installed = true
Dartium installed = true

@lrhn
Copy link
Member

lrhn commented Apr 17, 2012

The surprising thing is that it runs.
The code is:
 print('Previous value: $window.localStorage['test']');
if I read it correctly. The interpolation is only ${window}, and the rest of the string isn't part of it. To be correct, it should be:
 print('Previous value: ${window.localStorage['test']}');
As it's written, the string ends at the ' before test, and is followed by the raw identifier 'test', which isn't valid at that position.

How do you run it, and what result does it give?

@scheglov
Copy link
Contributor

See comment 1.


Added Invalid label.

@clayberg clayberg added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels Apr 20, 2012
dart-bot pushed a commit that referenced this issue Aug 11, 2020
> git log --oneline 04b054b62cc437cf23451785fdc50e49cd9de139..master
0d185a39 (HEAD -> master, origin/master, origin/HEAD) Push null-safety forwards to 2.11 (#2604)
56f9f27f Hide outdated --mode flag (#2603)
61ce6f81 Avoid double loop (#2605)
fa6e57d7 (disable_mixed_mode_validation) Fix outdated latest ordering (#2598)
6549e4aa Remove unused dependency from pubspec.yaml (#2592)
61543d07 Don't look for external package foo during testing (#2599)
590b448f Fixed license headers (#2595)
04e0601e Don't show entries for dev-dependencies in outdated --json --no-dev-dependencies (#2591)
8c3778c4 Configure GitHub move app (#2578)
eec7beca (top_level_command) Pass --(no-)sound-null-safety arg through to VM. (#2542)
152e4740 Warn about publishing in mixed mode (#2583)
0b7a3abe Removed april fools toys (#2325)
b74a5b73 Actually print hints (#2582)
8ec3a66d (pub2) Fix outdated --no-color (#2572)
7bb3d4e6 Use getSdkPath() in NullSafetyAnalysis (#2573)
3c578f24 Drop the "magic" package concept (#2577)
0e967ff0 Remove unused function (#2570)
988fefef Remove dependency overrides (#2568)

Change-Id: I58bf14234ed55bf9d825de60a40ded1d65281195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158003
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Development

No branches or pull requests

3 participants