IndexedDB should handle version change differences

[sethladd]

Chrome supports the old setVersion call, Firefox (and IE 10) support the new onversionchange callback. Our IndexedDB HTML lib should mask the differences, or at least allow us to manually handle both scenarios. This ensures the app runs on both Firefox and Chrome.

Here's the basic JavaScript code to handle both:

    if (db.setVersion && VERSION != db.version) {
      self.initWebkit(e);
    } else {
      self.init(e);
    }

idb.init = function(e) {
  this.db = e.target.result;
  this.db.onerror = onError;
  if (!this.db.objectStoreNames.contains(IMAGES_STORE)) {
    var store = this.db.createObjectStore(IMAGES_STORE, {keyPath: 'id', autoIncrement: true});
  }
};

idb.initWebkit = function(e) {
  this.db = e.target.result;
  this.db.onerror = onError;

  // Older implementations (Chrome) require creating object stores in setVersion().
  if (VERSION != this.db.version) {
    //var versionRequest = self.db.setVersion(VERSION);
    //versionRequest.onfailure = onError;
    var self = this;
    self.db.setVersion(VERSION).onsuccess = function(e) {
      /if (self.db.objectStoreNames.contains(IMAGES_STORE) {
        db.deleteObjectStore("todo");
      }/
      if (!self.db.objectStoreNames.contains(IMAGES_STORE)) {
        var store = self.db.createObjectStore(IMAGES_STORE, {keyPath: 'id', autoIncrement: true});
      }
      self.getAllImages();
    };
  } else {
    self.getAllImages();
  }
};

[rakudrama]

The code sample above does not actually use onversionchange.
Do you have working code that does?

[sethladd]

Oops, try this from Josh Bell: https://groups.google.com/a/chromium.org/group/chromium-discuss/browse_thread/thread/5d96ca12c2d092b6?pli=1

[rakudrama]

Marked this as blocking #1310.

[vsmenon]

Added this to the M1 milestone.

[iposva-google]

Removed Area-DOM label.
Added Area-HTML label.

[rakudrama]

Chrome 24 will support the standard 'upgradeNeeded' protocol.
setVersion is deprecated.

It is possible, if a little awkward, to write code in Dart that runs for both.
See https://chromiumcodereview.appspot.com/11052023/ for how the html tests were updated.
I slightly prefer the pattern in indexeddb_3_test.

I'd like to close this as 'WontFix' since Chrome 24 is on the Dev channel and can be expected to reach the stable channel in the usual Chrome release cycle.

---

cc @sethladd.
Set owner to @rakudrama.

[rakudrama]

Added WontFix label.

[rakudrama]

Issue #6446 has been merged into this issue.

[sethladd]

If you are looking for a work around, try http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tests/html/indexeddb_3_test.dart#­32