Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initKeyboardEvent args are very different between Webkit and FF #3005

Closed
jmesserly opened this issue May 10, 2012 · 7 comments
Closed

initKeyboardEvent args are very different between Webkit and FF #3005

jmesserly opened this issue May 10, 2012 · 7 comments
Assignees
@efortuna
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone
M2

Comments

@jmesserly
Copy link

See docs here:

http://api.dartlang.org/html/KeyboardEvent.html#initKeyboardEvent

The parameter names are a complete mismatch, leading the poor user (me) to be very confused :)
@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 14, 2012

Set owner to @rakudrama.
Added this to the M1 milestone.

@vsmenon
Copy link
Member

vsmenon commented Sep 5, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@rakudrama
Copy link
Member

Removed the owner.

@blois
Copy link
Contributor

blois commented Oct 17, 2012

Added keyboard label.

@efortuna
Copy link
Contributor

Set owner to @efortuna.

@efortuna
Copy link
Contributor

efortuna commented Dec 3, 2012

Fixed! We now "do the right thing" -- so there's a KeyboardEvent constructor, and it can handle both cases for FF or Webkit with a single interface to the user.

as of r15668 https://codereview.chromium.org//11299267

Added Fixed label.

@jmesserly jmesserly added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Dec 3, 2012
@jmesserly jmesserly added this to the M2 milestone Dec 3, 2012
dart-bot pushed a commit that referenced this issue May 21, 2021
@jonasfj
Bump pub.
5c9e37f 
New commits include:
```
git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
 def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
 e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
 d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
 492b15ba New binstubs for global activate using `dart pub` (#3002)
 e02f23bb fix grammer in .gitignore error message (#2995)
 e01e3a41 Use the frontend server to compile pub executables (#2968)
 647989c6 Use RetryClient from package:http/retry.dart (#2980)
```

Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue May 21, 2021
@jonasfj
Revert "Bump pub."
817cc85 
This reverts commit 5c9e37f.

Reason for revert: flutter builds on golem somehow broke.

Original change's description:
> Bump pub.
>
> New commits include:
> ```
> git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
>  def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
>  0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
>  e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
>  d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
>  492b15ba New binstubs for global activate using `dart pub` (#3002)
>  e02f23bb fix grammer in .gitignore error message (#2995)
>  e01e3a41 Use the frontend server to compile pub executables (#2968)
>  647989c6 Use RetryClient from package:http/retry.dart (#2980)
> ```
>
> Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=athom@google.com,jonasfj@google.com

Change-Id: I635e1c2db8ae965881359d4969cbd506348b0ed0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201000
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
dart-bot pushed a commit that referenced this issue May 25, 2021
@jonasfj
Reland "Bump pub."
1ee9b55 
This is a reland of 5c9e37f
Following update of `DEPS` in `flutter/engine`:
  flutter/engine#26395

New commits include:
```
git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
 def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
 e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
 d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
 492b15ba New binstubs for global activate using `dart pub` (#3002)
 e02f23bb fix grammer in .gitignore error message (#2995)
 e01e3a41 Use the frontend server to compile pub executables (#2968)
 647989c6 Use RetryClient from package:http/retry.dart (#2980)
```

Original change's description:
> Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>

Change-Id: I1a0570318c63ec97fd141d79b405f55105111077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201260
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efortuna efortuna

Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M2
Development

No branches or pull requests
6 participants
@jmesserly @rakudrama @efortuna @vsmenon @blois @iposva-google