-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add tests in samples/sample_extension to automated testing #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There shouldn't be a problem with the samples. The runtime checkout is not used on the buildbots so we have everything we need. One potential way to make this work out:
The buildbot can then be updated with another build and test step. |
Added this to the M1 milestone. |
OK, adding samples build target. |
The sample extension is still not tested automatically. We do have a test for the test_extension, in standalone/io/test_extension_test.dart, which should be adaptable to test the sample extension. |
Fixed in r26520 and r26512 : https://codereview.chromium.org/18073003/ Added Fixed label. |
New commits include: ``` git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569 def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008) 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009) e89d4ab8 Generate GNU-style long file names in tar archives (#3005) d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006) 492b15ba New binstubs for global activate using `dart pub` (#3002) e02f23bb fix grammer in .gitignore error message (#2995) e01e3a41 Use the frontend server to compile pub executables (#2968) 647989c6 Use RetryClient from package:http/retry.dart (#2980) ``` Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878 Auto-Submit: Jonas Jensen <jonasfj@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
This reverts commit 5c9e37f. Reason for revert: flutter builds on golem somehow broke. Original change's description: > Bump pub. > > New commits include: > ``` > git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569 > def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008) > 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009) > e89d4ab8 Generate GNU-style long file names in tar archives (#3005) > d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006) > 492b15ba New binstubs for global activate using `dart pub` (#3002) > e02f23bb fix grammer in .gitignore error message (#2995) > e01e3a41 Use the frontend server to compile pub executables (#2968) > 647989c6 Use RetryClient from package:http/retry.dart (#2980) > ``` > > Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878 > Auto-Submit: Jonas Jensen <jonasfj@google.com> > Commit-Queue: Alexander Thomas <athom@google.com> > Reviewed-by: Alexander Thomas <athom@google.com> TBR=athom@google.com,jonasfj@google.com Change-Id: I635e1c2db8ae965881359d4969cbd506348b0ed0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201000 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Jonas Jensen <jonasfj@google.com>
This is a reland of 5c9e37f Following update of `DEPS` in `flutter/engine`: flutter/engine#26395 New commits include: ``` git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569 def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008) 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009) e89d4ab8 Generate GNU-style long file names in tar archives (#3005) d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006) 492b15ba New binstubs for global activate using `dart pub` (#3002) e02f23bb fix grammer in .gitignore error message (#2995) e01e3a41 Use the frontend server to compile pub executables (#2968) 647989c6 Use RetryClient from package:http/retry.dart (#2980) ``` Original change's description: > Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878 > Auto-Submit: Jonas Jensen <jonasfj@google.com> > Commit-Queue: Alexander Thomas <athom@google.com> > Reviewed-by: Alexander Thomas <athom@google.com> Change-Id: I1a0570318c63ec97fd141d79b405f55105111077 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201260 Commit-Queue: Jonas Jensen <jonasfj@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
…25 revisions) https://dart.googlesource.com/dartdoc/+log/334072b0cad4..cf0685a2d1ce 2022-05-19 103135467+sealesj@users.noreply.github.com Create scorecards-analysis.yml (#3032) 2022-05-18 srawlins@google.com Add the docs.dart.js.map file to published package (#3042) 2022-05-17 parlough@gmail.com Reintroduce query param search (#3026) 2022-05-17 srawlins@google.com Include docs.dart.js in published code (#3040) 2022-05-17 parlough@gmail.com Optimize built js (#3028) 2022-05-17 srawlins@google.com Use dart run instead of deprecated dart pub run (#3038) 2022-05-17 timmaffett@gmail.com fix exception for empty dartdoc_options.yaml file (#3034) 2022-05-16 oss@simonbinder.eu Fix build config (#3035) 2022-05-02 goderbauer@google.com Drop version back to 5.1.0 (#3031) 2022-05-02 goderbauer@google.com Fixed: YouTube directive respects width/height argument (#3030) 2022-04-19 devoncarew@gmail.com Update pubspec.yaml (#3025) 2022-04-12 srawlins@google.com Remove dead field commentRefs, which is always empty (#3021) 2022-04-12 devoncarew@gmail.com make the converted web frontend follow Dart conventions (#3020) 2022-04-11 devoncarew@gmail.com convert lib/resources/script.js to Dart (#3016) 2022-04-11 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.1 to 3.0.2 (#3019) 2022-04-10 devoncarew@gmail.com rename the CI script (#3017) 2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 2 to 3.0.1 (#3014) 2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump markdown from 4.0.1 to 5.0.0 (#3015) 2022-04-08 srawlins@google.com Move many static declarations to top-level; avoid RegExp (#3009) 2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 2 to 3 (#3013) 2022-04-07 devoncarew@gmail.com Add a web frontend (#3011) 2022-04-07 devoncarew@gmail.com enable dependabot deps checks (#3012) 2022-04-07 srawlins@google.com Do not store the AstNode on ModelNode; eagerly grab the source indexes (#3008) 2022-04-07 srawlins@google.com Create a .pubignore in order to skip testing files from publish check (#3010) 2022-03-29 srawlins@google.com Bump to version 5.1.0 (#3006) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: dart-ecosystem-gardener@grotations.appspotmail.com Change-Id: I3467a27d6947c43f7f41acbb2959d72863fd8a34 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245483 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Devon Carew <devoncarew@google.com>
The sample extension should be built, and the tests run, on the buildbot.
There is a problem because the runtime checkout (DEPS.runtime) does not include the samples directory checkout.
This is related to issue dart:1817, about adding tests/standalone/io/test_extension_test.dart to the test scripts, but that issue will be easier to resolve because all parts are in the runtime checkout.
The text was updated successfully, but these errors were encountered: