Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the triple shift operator #30892

Closed
floitschG opened this issue Sep 26, 2017 · 2 comments
Closed

Implement the triple shift operator #30892

floitschG opened this issue Sep 26, 2017 · 2 comments
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) type-enhancement A request for a change that isn't a bug
Milestone
March Beta Release

Comments

@floitschG
Copy link
Contributor

floitschG commented Sep 26, 2017 •
edited by a-siva
Loading

Implement the triple shift operator per dart-lang/language#120 in the JIT/AOT modes.
@floitschG floitschG added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Sep 26, 2017
@floitschG floitschG mentioned this issue Jul 30, 2019
Closed
6 tasks
@leafpetersen leafpetersen added this to the March Beta Release milestone Feb 9, 2021
@leafpetersen leafpetersen mentioned this issue Feb 9, 2021
Closed
@a-siva a-siva changed the title Handle the unsigned shift operator in the VM Implement the triple shift operator per https://github.com/dart-lang/language/issues/120 Feb 9, 2021
@a-siva a-siva changed the title Implement the triple shift operator per https://github.com/dart-lang/language/issues/120 Implement the triple shift operator Feb 9, 2021
@a-siva a-siva added the type-enhancement A request for a change that isn't a bug label Feb 9, 2021
@a-siva
Copy link
Contributor

a-siva commented Feb 9, 2021

//cc @alexmarkov

@alexmarkov alexmarkov self-assigned this Feb 9, 2021
@alexmarkov alexmarkov mentioned this issue Feb 12, 2021
Closed
dart-bot pushed a commit that referenced this issue Feb 22, 2021
@alexmarkov
[core lib] Add unimplemented int.operator >>>
9d4ad8a 
This change adds a placeholder for int.operator >>>.
No implementation is added yet.

This change unblocks implementation of this operator in
the backends (VM, dart2js, DDC).

Issue: #44912
Issue: #30892
Change-Id: I9912ca9f44d594e9c5fa91f5fc65e807fe48cc7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185480
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
@alexmarkov alexmarkov mentioned this issue Feb 22, 2021
Closed
dart-bot pushed a commit that referenced this issue Feb 24, 2021
@alexmarkov
[vm] Support unsigned shift operator int.>>>
7f80012 
TEST=runtime/tests/vm/dart/unsigned_shift_right_test.dart and other
tests for >>>.

Issue #30892
Issue #44914

Change-Id: I7f0a9e1e486be06576c5d9bff3659b0aa6d68c23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184921
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
@alexmarkov
Copy link
Contributor

Unsigned right shift (aka triple shift) operator is implemented in VM/AOT in https://dart-review.googlesource.com/c/sdk/+/184921.

@eernstg eernstg added the implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
5 participants
@leafpetersen @floitschG @a-siva @eernstg @alexmarkov