Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Q1 2020 Small features release in the core libraries #44912

Closed
leafpetersen opened this issue Feb 9, 2021 · 5 comments
Closed

Implement Q1 2020 Small features release in the core libraries #44912

leafpetersen opened this issue Feb 9, 2021 · 5 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Milestone
March Beta Release

Comments

@leafpetersen
Copy link
Member

This tracks the implementation work in the core libraries for this feature.

cc @lrhn @franklinyow
@leafpetersen leafpetersen added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Feb 9, 2021
@leafpetersen leafpetersen added this to the February Beta Release milestone Feb 9, 2021
@leafpetersen leafpetersen mentioned this issue Feb 9, 2021
Closed
16 tasks
@alexmarkov
Copy link
Contributor

Optimized implementation of >>> in the VM (#30892) is blocked on changes in core libraries (we need to add operator >>> to int class first).

dart-bot pushed a commit that referenced this issue Feb 22, 2021
@alexmarkov
[core lib] Add unimplemented int.operator >>>
9d4ad8a 
This change adds a placeholder for int.operator >>>.
No implementation is added yet.

This change unblocks implementation of this operator in
the backends (VM, dart2js, DDC).

Issue: #44912
Issue: #30892
Change-Id: I9912ca9f44d594e9c5fa91f5fc65e807fe48cc7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185480
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
@leafpetersen
Copy link
Member Author

@lrhn @alexmarkov where are we with this?

@alexmarkov
Copy link
Contributor

VM fully implements int.operator >>> (7f80012).

@franklinyow
Copy link
Contributor

Any other work still needed?

@leafpetersen
Copy link
Member Author

I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
4 participants
@lrhn @leafpetersen @alexmarkov @franklinyow