Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analzyer: report error overriding a static variable with an instance variable? #3656

Closed
DartBot opened this issue Jun 14, 2012 · 9 comments
Closed

Analzyer: report error overriding a static variable with an instance variable? #3656

DartBot opened this issue Jun 14, 2012 · 9 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 14, 2012

This issue was originally filed by zundel@google.com

I'm not sure if this test is valid or not - only the VM passes it now. Need to investigate the spec first.

language/override_field_test/04

cat enerated_tests/language/override_field_test_04.dart

class A {
  static int staticFieldInA;
}

class B extends A {
  int instanceFieldInA; /// 04: compile-time error
}
@DartBot
Copy link
Author

DartBot commented Jun 15, 2012

This comment was originally written by zundel@google.com

Added this to the M1 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 27, 2012

This comment was originally written by zundel@google.com

This test is out of date. The spec calls for a static-type warning in version 0.10 section 7.1

Removed Area-Analyzer label.
Added Area-Test label.

@dgrove
Copy link
Contributor

dgrove commented Oct 15, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@DartBot DartBot added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
copybara-service bot pushed a commit that referenced this issue Nov 25, 2022
@sigurdm
Bump pub to 6fdcd and webdev to 637b4
28be06f 
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to
override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/

Bump webdev to 637b406f325669507b5c1048c19a7c0083c1bd6e

Changes:
```
> git log --format="%C(auto) %h %s" 3ec168f..637b406
 https://dart.googlesource.com/webdev.git/+/637b406 Support `--native-assets` in `FrontendServerClient` (#1797)
 https://dart.googlesource.com/webdev.git/+/a19d563 Save debug information in `chrome.storage` after a Dart app loads  (#1791)
 https://dart.googlesource.com/webdev.git/+/9cc10d4 Connect to a `chrome.runtime` port to keep the service worker alive  (#1789)

```
Diff: https://dart.googlesource.com/webdev.git/+/3ec168f6815af9d5f11278111d147bc82c0755c3~..637b406f325669507b5c1048c19a7c0083c1bd6e/


Update CHANGELOG


Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/
Change-Id: I65b928479b44f08305853078b0f34a6b66602709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271709
Auto-Submit: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @dgrove @kasperl @anders-sandholm @larsbak @Markzipan @DartBot