Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on Account for @pragma("vm:entry-point") creating additional "root" libraries when partitioning the program into loading units. #49325

Closed
mkustermann opened this issue Jun 24, 2022 · 1 comment
Closed

Failures on Account for @pragma("vm:entry-point") creating additional "root" libraries when partitioning the program into loading units. #49325

mkustermann opened this issue Jun 24, 2022 · 1 comment
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@mkustermann
Copy link
Member

There are new test failures on Account for @pragma("vm:entry-point") creating additional "root" libraries when partitioning the program into loading units..

The tests

co19/Language/Libraries_and_Scripts/Scripts/top_level_main_t02 Crash (expected Pass)
language/export/main_test Crash (expected Pass)
language_2/export/main_test Crash (expected Pass)
vm/dart/emit_aot_size_info_flag_test RuntimeError (expected Pass)
vm/dart/use_code_comments_flag_test RuntimeError (expected Pass)
vm/dart_2/emit_aot_size_info_flag_test RuntimeError (expected Pass)
vm/dart_2/use_code_comments_flag_test RuntimeError (expected Pass)

are failing on configurations

dartkp-android-release-arm64c
dartkp-android-release-arm_x64
dartkp-asan-linux-release-x64
dartkp-dwarf-linux-product-x64
dartkp-linux-debug-simarm-crossword
dartkp-linux-debug-simriscv64
dartkp-linux-debug-x64
dartkp-linux-debug-x64c
dartkp-linux-product-x64
dartkp-linux-release-arm64
dartkp-linux-release-simarm
dartkp-linux-release-simarm-crossword
dartkp-linux-release-simarm64
dartkp-linux-release-x64
dartkp-mac-release-simarm64
dartkp-msan-linux-release-x64
dartkp-obfuscate-linux-release-x64
dartkp-strong-linux-debug-simarm-crossword
dartkp-strong-linux-debug-x64
dartkp-strong-linux-release-simarm-crossword
dartkp-strong-linux-release-simarm64
dartkp-strong-linux-release-x64
dartkp-strong-mac-release-arm64
dartkp-strong-mac-release-simarm64
dartkp-strong-win-release-x64
dartkp-tsan-linux-release-x64
dartkp-ubsan-linux-release-x64
dartkp-weak-asserts-linux-debug-simarm-crossword
dartkp-weak-asserts-linux-debug-x64
dartkp-weak-asserts-linux-release-simarm-crossword
dartkp-weak-asserts-linux-release-simarm64
dartkp-weak-asserts-linux-release-x64
dartkp-weak-asserts-mac-release-arm64
dartkp-weak-asserts-mac-release-simarm64
dartkp-weak-asserts-win-release-x64
dartkp-win-debug-x64c
dartkp-win-product-x64
dartkp-win-release-x64
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jun 24, 2022
@mkustermann
Copy link
Member Author

Reverted as c13f7b0

copybara-service bot pushed a commit that referenced this issue Jun 27, 2022
@rmacnak-google
Reapply "Account for @pragma("vm:entry-point") creating additional "r…
93a4247 
…oot" libraries when partitioning the program into loading units."

Weaken assertion in gen_snapshot requiring all libraries to have a loading unit as there can still be unreachable libraries:
  - Google3 and Fuchsia will compile all the sources in a package to a single dill file, then present multiple input dill files to the AOT compilation. Since the set of libraries was derived from package membership instead of imports, many can be unreachable.
  - When the root library's main comes from an export, the frontend's representation will incorrectly report the library containing main as the root library and the true root library may be unreachable from it.

Instead, assert only that surviving compiled code is assigned a loading unit.

TEST=gallery
Bug: flutter/gallery#545
Bug: #49325
Bug: #41974
Bug: b/237016312
Change-Id: Ia52563a6f517308d041368be11dcc85270f19acc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249724
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkustermann @rmacnak-google