This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Deferred components causes release builds to fail #545
Comments
|
cc @rmacnak-google gen_snapshot seems to be segfaulting with -6. There have not been any gallery changes and I am still bisecting when this began to occur. It seems to happened beyond a week ago. |
|
cc @rmacnak-google Have you had a chance to look at this? |
|
Hey wondering if there's an update on this? |
|
friendly ping for an update |
|
Still reproes |
|
Same here, no problem with apk release, but for appbundle, build will fail without |
|
/cc @a-siva seems like deferred components are broken for a while? |
|
Same here. Flutter tools is v3.0.2. Gallery branch is master. Run 'flutter build appbundle --verbose' and report the same error. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Jun 23, 2022
…aries when partitioning the program into loading units. If a library contained an entry point but was not reachable from the root library, it was not assigned to any loading unit and caused a null dereference in gen_snapshot. This is not possible with the standalone embedder, but is possible in Flutter because it passes multiple sources to frontend_server. E.g., `--source dart_plugin_registrant.dart`. TEST=gallery Bug: flutter/gallery#545 Change-Id: I9c67f0e39f7509094ee873610d80851a702a0cf2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249640 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Jun 24, 2022
…ot" libraries when partitioning the program into loading units." This reverts commit 9c2a91f. Reason for revert: breaks google3 (b/237016312) Original change's description: > Account for @pragma("vm:entry-point") creating additional "root" libraries when partitioning the program into loading units. > > If a library contained an entry point but was not reachable from the root library, it was not assigned to any loading unit and caused a null dereference in gen_snapshot. This is not possible with the standalone embedder, but is possible in Flutter because it passes multiple sources to frontend_server. E.g., `--source dart_plugin_registrant.dart`. > > TEST=gallery > Bug: flutter/gallery#545 > Change-Id: I9c67f0e39f7509094ee873610d80851a702a0cf2 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249640 > Reviewed-by: Alexander Markov <alexmarkov@google.com> > Commit-Queue: Ryan Macnak <rmacnak@google.com> TBR=rmacnak@google.com,alexmarkov@google.com Change-Id: I3e17bf29b8f29e4797abfca35fa82b9ca3b5a160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: flutter/gallery#545 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249681 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com> Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Jun 27, 2022
…oot" libraries when partitioning the program into loading units." Weaken assertion in gen_snapshot requiring all libraries to have a loading unit as there can still be unreachable libraries: - Google3 and Fuchsia will compile all the sources in a package to a single dill file, then present multiple input dill files to the AOT compilation. Since the set of libraries was derived from package membership instead of imports, many can be unreachable. - When the root library's main comes from an export, the frontend's representation will incorrectly report the library containing main as the root library and the true root library may be unreachable from it. Instead, assert only that surviving compiled code is assigned a loading unit. TEST=gallery Bug: flutter/gallery#545 Bug: #49325 Bug: #41974 Bug: b/237016312 Change-Id: Ia52563a6f517308d041368be11dcc85270f19acc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249724 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
|
Me too！！！ Run 'flutter build appbundle --verbose' and report the same error. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Jun 30, 2022
Cf. 4c82eb5 TEST=gallery Bug: flutter/gallery#545 Change-Id: I90935aba3737f7b6873368e5a8ebf1cc48d34a22 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250320 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
|
Same problem. flutter build appbundle fail only with deferred components Flutter (Channel stable, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale it-IT) |
guidezpl
pushed a commit
that referenced
this issue
Jul 7, 2022
Seven-112
pushed a commit
to Seven-112/gallery
that referenced
this issue
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
flutter build appbundle -v --no-deferred-componentssuccessfully completes, whereasflutter build appbundle -vfails:The text was updated successfully, but these errors were encountered: