Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec seemingly allows for classes to be used as an interface's superinterfaces, but the actual implementation doesn't #554

Closed
DartBot opened this issue Nov 22, 2011 · 4 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant

Comments

@DartBot
Copy link

DartBot commented Nov 22, 2011

This issue was originally filed by rodion...@unipro.ru


Chapter 8.4 of the spec says:
It is a compile-time error if the extends clause of an interface I includes a type expression that does not denote a class or interface available in the lexical scope of I.

yet it is a compile-time error if you actually try to use a class name there

@DartBot
Copy link
Author

DartBot commented Nov 22, 2011

This comment was originally written by drfibonacci@google.com


Added Area-Language, Triaged labels.

@gbracha
Copy link
Contributor

gbracha commented Nov 30, 2011

This is a bug in our implementations, not the spec.


Removed Area-Language label.
Added Area-Compiler label.

@DartBot
Copy link
Author

DartBot commented Dec 26, 2011

This comment was originally written by ief...@unipro.ru


The same bug is actual for Dart VM (r2810)
co19 tests
LangSpecTest/08_Interfaces/4/Superinterfaces/A02/t04
LangSpecTest/07_Classes/9/Superinterfaces/A02/t04

@DartBot
Copy link
Author

DartBot commented Mar 28, 2012

This comment was originally written by zundel@google.com


These tests no longer marked as failing in co19-compiler.status


Added AssumedStale label.

@DartBot DartBot added Type-Defect closed-obsolete Closed as the reported issue is no longer relevant labels Mar 28, 2012
copybara-service bot pushed a commit that referenced this issue May 20, 2022
Changes:
```
> git log --format="%C(auto) %h %s" c1eb6cb..b149f80
 https://dart.googlesource.com/protobuf.git/+/b149f80 Remove the top level analysis_options.yaml file (#656)
 https://dart.googlesource.com/protobuf.git/+/8f6f307 Fix comment syntax
 https://dart.googlesource.com/protobuf.git/+/665f7b0 Remove trailing whitespace in protobuf/LICENSE
 https://dart.googlesource.com/protobuf.git/+/9ffbaf2 Fix default list type for frozen messages (#654)
 https://dart.googlesource.com/protobuf.git/+/a68bb5a Fix Fixed32 to be parsed as unsigned when parsing proto3 protos (#655)
 https://dart.googlesource.com/protobuf.git/+/6957c98 Convert the field started with underscore and digit to a legal name (#651)
 https://dart.googlesource.com/protobuf.git/+/71defca Account for double.infinity and double.nan in json serializers (#652)
 https://dart.googlesource.com/protobuf.git/+/5a48349 Allow `Timestamp.toDateTime()` to return a `DateTime` in local timezone (#653)
 https://dart.googlesource.com/protobuf.git/+/117e869 Make the toString of enums be the value if names are omitted (#649)
 https://dart.googlesource.com/protobuf.git/+/88c4016 Align the hashCode of a message with an empty unknown field-set with that of no unknown field set (#648)
 https://dart.googlesource.com/protobuf.git/+/eed09c4 Fix proto3 repeated field encoding without packed option (#635)
 https://dart.googlesource.com/protobuf.git/+/8f587b1 Simplify `_FieldSet` getters (#646)
 https://dart.googlesource.com/protobuf.git/+/494f189 Fix compile-protos.sh interpreter (#645)
 https://dart.googlesource.com/protobuf.git/+/5e1a422 Fix typo in protobuf-0.9.0+1 changelog
 https://dart.googlesource.com/protobuf.git/+/46df68a Add `UseResult` annotation to `rebuild` (#631)
 https://dart.googlesource.com/protobuf.git/+/ff5304f Migrate protoc_plugin to null safety (#642)
 https://dart.googlesource.com/protobuf.git/+/657197d Fix typo in GeneratedMessage.copyWith documentation (#641)
 https://dart.googlesource.com/protobuf.git/+/e30a522 Fix sharing coded buffer bytes when parsing `bytes` fields (#640)
 https://dart.googlesource.com/protobuf.git/+/810b166 Clear unknown field when setting an extension field with the same tag (#639)
 https://dart.googlesource.com/protobuf.git/+/d30623b Treat empty and uninitialized Maps the same in equality checks (#638)
 https://dart.googlesource.com/protobuf.git/+/4fe3ee4 Make `MapFieldInfo` key and value types non-nullable (#600)
 https://dart.googlesource.com/protobuf.git/+/c26ac34 Add grpc example to protoc_plugin README (#514)
 https://dart.googlesource.com/protobuf.git/+/c35d787 Revert changes to reserved names to maintain backwards compat (#636)
 https://dart.googlesource.com/protobuf.git/+/146b186 Remove unused `GeneratedMessage` constructors (#634)
 https://dart.googlesource.com/protobuf.git/+/1b12ac9 Remove a closure in `_FieldSet.hashCode` (#633)
 https://dart.googlesource.com/protobuf.git/+/5731242 Minor fix in query_bench set_nested_value benchmark: (#630)
 https://dart.googlesource.com/protobuf.git/+/767ce81 Remove fold() closures from `FieldSet._hashCode`. (#554)
 https://dart.googlesource.com/protobuf.git/+/99bc541 protoc_plugin README fixes and tweaks: (#617)
 https://dart.googlesource.com/protobuf.git/+/e282e17 protobuf benchs: invoke protoc once with all protos (#623)
 https://dart.googlesource.com/protobuf.git/+/bef672b protobuf benchs: fix old --trust-type-annotations flag (#622)
 https://dart.googlesource.com/protobuf.git/+/d072e5f dependabot: check for updates monthly (#620)
 https://dart.googlesource.com/protobuf.git/+/96bdf38 Fix TypeRegistry passing when unpacking nested Any messages from JSON (#568)
 https://dart.googlesource.com/protobuf.git/+/4ec722a Correctly combine hash codes for repeated enums. (#556)
 https://dart.googlesource.com/protobuf.git/+/b96dc21 Testing: don't return static methods in findMemberNames (#618)
 https://dart.googlesource.com/protobuf.git/+/09e8a8d Update protobuf/benchmarks README for #553
 https://dart.googlesource.com/protobuf.git/+/3ef4539 Add a benchmark for computing hashCodes. (#553)
 https://dart.googlesource.com/protobuf.git/+/d232e6e Tweak READMEs: (#610)
 https://dart.googlesource.com/protobuf.git/+/0f01fa9 Update protobuf pubspec.yaml (#616)
 https://dart.googlesource.com/protobuf.git/+/a10426b Update protoc_plugin pubspec.yaml (#615)
 https://dart.googlesource.com/protobuf.git/+/a0021c7 Make `protoName` unCamelCase lazy (#606)
 https://dart.googlesource.com/protobuf.git/+/ded1ac7 Document map key and value fields (#603)
 https://dart.googlesource.com/protobuf.git/+/8792f2a Remove redundant check in PbMap equality check (#604)
 https://dart.googlesource.com/protobuf.git/+/b7f9569 Tweak BuilderInfo and FieldInfo docs: (#597)
 https://dart.googlesource.com/protobuf.git/+/6f85c32 Remove a redundant cast (#598)
 https://dart.googlesource.com/protobuf.git/+/3df8669 Latest mono_repo (#601)
 https://dart.googlesource.com/protobuf.git/+/9da84ae Fix a potential issue in CodedBufferWriter (#594)
 https://dart.googlesource.com/protobuf.git/+/6be405f Remove old and unused test file (#589)
 https://dart.googlesource.com/protobuf.git/+/900cef5 Fix protoc_plugin run-tests make rule (#586)
 https://dart.googlesource.com/protobuf.git/+/2546269 Fix rounding when handling negative timestamps (#580)
 https://dart.googlesource.com/protobuf.git/+/8afce8d Fix Readme `pub get` instead of `pub install`. (#486)
 https://dart.googlesource.com/protobuf.git/+/782fd24 Avoid runtime function type check in lazily created singleton creator functions (#574)
 https://dart.googlesource.com/protobuf.git/+/a7e75cb Update README.md
 https://dart.googlesource.com/protobuf.git/+/23136dc Version bump (#563)
 https://dart.googlesource.com/protobuf.git/+/18346f5 Convert null keys and values to default when parsing map entries (#536)
 https://dart.googlesource.com/protobuf.git/+/bb4cf0b Bump to latest mono_repo - use latest actions (#561)
 https://dart.googlesource.com/protobuf.git/+/835ab75 Remove unneeded imports
 https://dart.googlesource.com/protobuf.git/+/ef733ac latest mono_repo
 https://dart.googlesource.com/protobuf.git/+/ecfb862 Fix test for latest analysis (#543)
 https://dart.googlesource.com/protobuf.git/+/26a0a26 fix insecure link in protoc_plugin readme
 https://dart.googlesource.com/protobuf.git/+/444e855 Bump dart-lang/setup-dart from 1.1 to 1.2 (#535)
 https://dart.googlesource.com/protobuf.git/+/d3e0e4a Fix analysis options
 https://dart.googlesource.com/protobuf.git/+/cf29280 Fix comment references

```

Diff: https://dart.googlesource.com/protobuf.git/+/c1eb6cb51af39ccbaa1a8e19349546586a5c8e31~..b149f801cf7a5e959cf1dbf72d61068ac275f24b/

Tested: relying on existing SDK and protobuf tests
Change-Id: I7f89b998a0aba13999d180ee9814a26a5f1d054d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245228
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Sep 1, 2023
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/b65622a..75efa6c):
  75efa6c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#250)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf):
  f950bbf  2023-08-31  Parker Lougheed  Regenerate worker protocol protos to add constructors and comments (#78)
  9b4c6a0  2023-08-30  Parker Lougheed  Update e2e_test dependencies (#79)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921):
  f255921  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#50)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393):
  1f69393  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#48)

cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3):
  44118e3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#88)

clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08):
  1e75f08  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f):
  c058c8f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#86)

crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879):
  1e26879  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#151)

csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a):
  bd30a1a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#188)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218):
  695b218c  2023-08-30  Sam Rawlins  Tidy Category: (#3488)
  b26af96f  2023-08-30  Sam Rawlins  Tidy up library exports (#3487)
  be35cb00  2023-08-29  Devon Carew  Update dependabot.yaml (#3486)
  649bb8d2  2023-08-29  Sam Rawlins  Migrate to create_api_docs.dart (#3482)

ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de):
  89e58de  2023-09-01  Hossein Yousefi  also install flutter on validate (#160)
  f95d0f2  2023-09-01  Hossein Yousefi  Add use-flutter arg to validate (#159)
  8743a9d  2023-09-01  Moritz  Pass a parameter for Flutter `firehose` support (#158)
  54d1628  2023-08-31  Moritz  Setup Flutter in publish workflow (#157)
  8fa89c6  2023-08-31  Moritz  Add flutter support (#155)
  65817bf  2023-08-29  Moritz  Switch to Pub API (#152)

ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a):
  d36e05a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#208)

fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065):
  87ed065  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#114)

http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6):
  7fb6fd6  2023-08-31  Brian Quinlan  Clarify how to set the body without a content type header (#1014)

lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3):
  da44af3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#144)

logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f):
  bcaad0f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#147)

markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1):
  6cfd6f1  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#554)
  52be591  2023-08-30  Parker Lougheed  Fix a few more lints, no longer ignore line length (#552)

matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6):
  80910d6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#227)

mime (https://github.com/dart-lang/mime/compare/799b398..37ef637):
  37ef637  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#104)

native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc):
  a2dfedc  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#117)
  8dfb0d2  2023-09-01  dependabot[bot]  Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118)

path (https://github.com/dart-lang/path/compare/7c2324b..96d9183):
  96d9183  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35):
  a5bee35  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#73)

shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76):
  2926f76  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#376)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf):
  196d7bf  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588):
  eeb2588  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#87)
  2bb1a6e  2023-09-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88)

stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b):
  bcf2a0b  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#140)

stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6):
  0ce7ab6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#94)

string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c):
  da9142c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#62)

term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285):
  1b28285  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1):
  27dcae11  2023-09-01  dependabot[bot]  Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086)
  cf0a0a73  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#2085)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d):
  030193d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23):
  2a6ee23  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#47)

tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6):
  2c8cbd6  2023-09-01  Jonas Finnemann Jensen  Extension discovery 2.0.0 (#156)
  3e12c2e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#157)
  0f28f80  2023-08-28  Kenzie Davisson  Prepare extension_discovery for 1.0.1 release (#154)

typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943):
  80e8943  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#72)

watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e):
  1aed03e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#149)

yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187):
  ae00187  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d):
  4a9734d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#56)
  83f9033  2023-07-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#54)

Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

2 participants