frog not giving error/warning on missing return statement

[DartBot]

This issue was originally filed by mattsh@google.com

---

It would be good if frog could give an error/warning if you declare a function return type, but forget to include a return statement.

e.g.

String foo() { }

should give an error/warning.

[jmesserly]

I don't think this is a warning in Dart. All functions have an implicit "return null" if they do not contain an explicit return (In section 6 "Functions": "If the last statement of a function is not a return statement, the statement 'return null;' is implicitly appended to the function body.")

I'm not generally opposed to making this a warning, but I would double check with Gilad what he intends for this. There is a warning spec'd for "return;" without an expression--so it might just be an oversight (or I'm misreading that part of the spec)

---

Added Invalid label.

[DartBot]

This comment was originally written by mattsh@google.com

---

Assigning to Gilad. Is it OK to give a warning if the user doesn't have a return statement (assuming the function is explicitly typed to have a return type like String)? (I'm pretty sure there was an email discussion on this a while back, and the conclusion was that there should be a warning if the function has a return type other than <dynamic> or void, and the user does not put a return statement in the code.)

---

Set owner to @gbracha.
Removed Area-Frog label.
Added Area-Language, Triaged labels.

[gbracha]

The plan is (and has been all along) to add a check for such situations, but it has not been specified yet.

---

Removed Type-Defect label.
Added Type-Enhancement, Accepted labels.

[DartBot]

This comment was originally written by mattsh@google.com

---

Assigning back to frog. I just had a small bug that would have been caught by this, so it would be pretty helpful to have this I think.

---

Set owner to @jmesserly.
Added Triaged label.

[gbracha]

FWIW, this did not get reclassified as Frog. John, if you no longer care about it, please close it.

---

Removed Area-Language label.
Added Area-Frog label.

[anders-sandholm]

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

[kasperl]

Added WontFix label.